From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53752)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laijs@cn.fujitsu.com>) id 1SEtmJ-0001bu-7T
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 22:47:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laijs@cn.fujitsu.com>) id 1SEtmH-00042R-A7
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 22:47:26 -0400
Received: from [222.73.24.84] (port=62940 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laijs@cn.fujitsu.com>) id 1SEtmG-00041l-Vc
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 22:47:25 -0400
Message-ID: <4F7A65F5.8070807@cn.fujitsu.com>
Date: Tue, 03 Apr 2012 10:52:37 +0800
From: Lai Jiangshan <laijs@cn.fujitsu.com>
MIME-Version: 1.0
References: <4F7948B2.4090100@cn.fujitsu.com> <4F797660.4070907@suse.de>
In-Reply-To: <4F797660.4070907@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] use: fix bit test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 04/02/2012 05:50 PM, Andreas F=C3=A4rber wrote:
> Am 02.04.2012 08:35, schrieb Lai Jiangshan:
>>
>> use & instead of the wrong &&
>>
>> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>=20
> Patch looks okay but the subject should probably be fixed to say "usb:"
> when applying. :)
>=20

Thank you!!

Hi, Gerd,

Does this patch have any problem?
could you merge it with "use:"->"usb:" in the title.
(I think it is not good to send another patch for this)

Thanks
Lai

>=20
>> ---
>> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
>> index 73b0c7f..89c2406 100644
>> --- a/hw/usb/hcd-xhci.c
>> +++ b/hw/usb/hcd-xhci.c
>> @@ -502,7 +502,7 @@ static void xhci=5Firq=5Fupdate(XHCIState *xhci)
>>      int level =3D 0;
>> =20
>>      if (xhci->iman & IMAN=5FIP && xhci->iman & IMAN=5FIE &&
>> -        xhci->usbcmd && USBCMD=5FINTE) {
>> +        xhci->usbcmd & USBCMD=5FINTE) {
>>          level =3D 1;
>>      }
>> =20
>=20

=