From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] bootm: fix usage of lmb_reserve()
Date: Tue, 03 Apr 2012 12:32:31 +0200 [thread overview]
Message-ID: <4F7AD1BF.10507@gmail.com> (raw)
In-Reply-To: <1333448187-7456-1-git-send-email-andreas.devel@googlemail.com>
Hi,
On 03.04.2012 12:16, Andreas Bie?mann wrote:
> From: Andreas Bie?mann <biessmann@corscience.de>
>
> commit 44f074c771c4b70d250b0d7ed2f7513488c678bb brakes compiling avr32 boards
> which do not have CONFIG_LMB. This patch re-add the empty lmb_reserve() define
> to opt-out respective code parts in do_bootm() and do_bootm_subcommand().
>
> This patch fixes errors like this:
> ---8<---
> cmd_bootm.c: In function 'do_bootm_subcommand':
> cmd_bootm.c:518: error: 'bootm_headers_t' has no member named 'lmb'
> cmd_bootm.c: In function 'do_bootm':
> cmd_bootm.c:665: error: 'bootm_headers_t' has no member named 'lmb'
> --->8---
again days to late and about half an hour unnecessary work ... should
really check ML more often.
http://patchwork.ozlabs.org/patch/149924/ was before.
> Signed-off-by: Andreas Bie?mann <biessmann@corscience.de>
> ---
> common/cmd_bootm.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index 9ad2535..7d72c7a 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -186,6 +186,8 @@ static void boot_start_lmb(bootm_headers_t *images)
> board_lmb_reserve(&images->lmb);
> }
> #else
> +/* we want to opt-out access to images.lmb by precompiler !*/
I would like to have some comment like this in the other patch.
regards
Andreas Bie?mann
next prev parent reply other threads:[~2012-04-03 10:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 10:16 [U-Boot] [PATCH] bootm: fix usage of lmb_reserve() Andreas Bießmann
2012-04-03 10:32 ` Andreas Bießmann [this message]
2012-04-03 13:43 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7AD1BF.10507@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.