From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47742)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SF1nR-0004xV-SI
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:21:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SF1nJ-0004Z7-61
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:21:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1025)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SF1nI-0004YZ-T1
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:21:01 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q33BKxEC006243
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 3 Apr 2012 07:20:59 -0400
Message-ID: <4F7ADDF5.1030703@redhat.com>
Date: Tue, 03 Apr 2012 13:24:37 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <888ccd7cf8f0c8ad69a34fb28785744abe85df8f.1332880179.git.jcody@redhat.com>
In-Reply-To: <888ccd7cf8f0c8ad69a34fb28785744abe85df8f.1332880179.git.jcody@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block: bdrv_append() fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

Am 27.03.2012 22:30, schrieb Jeff Cody:
> A few fixups for bdrv_append():
> 
> The new bs (bs_new) passed into bdrv_append() should be anonymous.  Rather
> than call bdrv_make_anon() to enforce this, use an assert to catch when a caller
> is passing in a bs_new that is not anonymous.
> 
> Also, the new top layer should have its backing_format reflect the original
> top's format.
> 
> And last, after the swap of bs contents, the device_name will have been copied
> down. This needs to be cleared to reflect the anonymity of the bs that was
> pushed down.
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>

Thanks, applied to the block branch.

Kevin