All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhi Hui Li <zhihuili@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: zhihuili@cn.ibm.com, QEMU-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c.
Date: Tue, 03 Apr 2012 19:53:23 +0800	[thread overview]
Message-ID: <4F7AE4B3.2090309@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120402123053.GB23753@stefanha-thinkpad.localdomain>


I think what you say up is right, I will correct them, thank you very much!

>> +        bdrv_aio_readv(cur_drv->bs, fd_sector(cur_drv),
>> +&fdctrl->qiov, fdc_sector_num, fdctrl_read_DMA_cb, opaque_cb);
>> +        return dma_len;
>
> Should be return 0 since we haven't completed I/O yet.
>
> Stefan
>
>

I think the return value is not used not, so no matter what is returned 
it not necessary.

if set the dma_len = 0, when call void DMA_set_return(int nret)
function will return the real value;

:)

  reply	other threads:[~2012-04-03 11:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-31 13:19 [Qemu-devel] [PATCH v3] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c Li Zhi Hui
2012-04-02 12:30 ` Stefan Hajnoczi
2012-04-03 11:53   ` Zhi Hui Li [this message]
2012-04-03 15:53     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7AE4B3.2090309@linux.vnet.ibm.com \
    --to=zhihuili@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=zhihuili@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.