From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF2qu-0005YQ-So for qemu-devel@nongnu.org; Tue, 03 Apr 2012 08:28:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SF2qo-0006re-Lt for qemu-devel@nongnu.org; Tue, 03 Apr 2012 08:28:48 -0400 Received: from david.siemens.de ([192.35.17.14]:24833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF2qo-0006r7-Bo for qemu-devel@nongnu.org; Tue, 03 Apr 2012 08:28:42 -0400 Message-ID: <4F7AECF5.3020402@siemens.com> Date: Tue, 03 Apr 2012 14:28:37 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1333451753-3550-1-git-send-email-pbonzini@redhat.com> <1333451753-3550-8-git-send-email-pbonzini@redhat.com> In-Reply-To: <1333451753-3550-8-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, afaerber@suse.de On 2012-04-03 13:15, Paolo Bonzini wrote: > Otherwise, non-string properties without a legacy counterpart are missed. > Also fix error propagation in object_property_print itself, otherwise > pointer properties are printed as "". > > Signed-off-by: Paolo Bonzini > --- > hw/qdev-monitor.c | 2 +- > qom/object.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c > index 0acfc82..07ac525 100644 > --- a/hw/qdev-monitor.c > +++ b/hw/qdev-monitor.c > @@ -492,7 +492,7 @@ static void qdev_print_props(Monitor *mon, DeviceState *dev, Property *props, > if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) { > value = object_property_get_str(OBJECT(dev), legacy_name, &err); This is not a criticism on this patch, but I'd like to underline that the line above only works because legacy props also define print handlers. [qdev_property_add_legacy] object_property_add(OBJECT(dev), name, type, prop->info->print ? qdev_get_legacy_property : prop->info->get, prop->info->parse ? qdev_set_legacy_property : prop->info->set, NULL, prop, errp); But this statement above is still inconsistent. We should either assert(print && parse) or handle their non-existence properly. > } else { > - value = object_property_get_str(OBJECT(dev), props->name, &err); > + value = object_property_print(OBJECT(dev), props->name, &err); > } > g_free(legacy_name); > > diff --git a/qom/object.c b/qom/object.c > index f3ffaa6..ff36946 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -850,7 +850,7 @@ char *object_property_print(Object *obj, const char *name, > char *string; > > mo = string_output_visitor_new(); > - object_property_get(obj, string_output_get_visitor(mo), name, NULL); > + object_property_get(obj, string_output_get_visitor(mo), name, errp); > string = string_output_get_string(mo); > string_output_visitor_cleanup(mo); > return string; Patch works for me. Thanks, Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux