From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC][PATCH v2 0/4] uq/master: Basic MSI support for in-kernel irqchip mode Date: Tue, 03 Apr 2012 19:27:36 +0200 Message-ID: <4F7B3308.5060700@siemens.com> References: <20120403130604.GA11053@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel To: "Michael S. Tsirkin" Return-path: Received: from goliath.siemens.de ([192.35.17.28]:22831 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753239Ab2DCR1p (ORCPT ); Tue, 3 Apr 2012 13:27:45 -0400 In-Reply-To: <20120403130604.GA11053@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-04-03 15:06, Michael S. Tsirkin wrote: > On Tue, Apr 03, 2012 at 09:23:12AM +0200, Jan Kiszka wrote: >> This is v2 of the RFC, fixing a memory leak in >> kvm_flush_dynamic_msi_routes and adding support for the proposed >> KVM_SIGNAL_MSI IOCTL. >> >> This series depends on "kvm: set gsi_bits and max_gsi correctly" >> (http://thread.gmane.org/gmane.comp.emulators.kvm.devel/88906). > > Looks good to me. > How hard would it be to add irqfd support? Shouldn't be, but the changes will be a bit bigger. I'm thinking about a revamped interface between the MSI core and affected devices for a while. Will try to put down in some lines of code what I have in mind - once the dynamic MSI injection topic has settled. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF7WE-00068w-0p for qemu-devel@nongnu.org; Tue, 03 Apr 2012 13:27:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SF7W9-0001gv-7e for qemu-devel@nongnu.org; Tue, 03 Apr 2012 13:27:45 -0400 Received: from goliath.siemens.de ([192.35.17.28]:27083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF7W8-0001gc-TO for qemu-devel@nongnu.org; Tue, 03 Apr 2012 13:27:41 -0400 Message-ID: <4F7B3308.5060700@siemens.com> Date: Tue, 03 Apr 2012 19:27:36 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20120403130604.GA11053@redhat.com> In-Reply-To: <20120403130604.GA11053@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH v2 0/4] uq/master: Basic MSI support for in-kernel irqchip mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Marcelo Tosatti , Avi Kivity , kvm@vger.kernel.org, qemu-devel On 2012-04-03 15:06, Michael S. Tsirkin wrote: > On Tue, Apr 03, 2012 at 09:23:12AM +0200, Jan Kiszka wrote: >> This is v2 of the RFC, fixing a memory leak in >> kvm_flush_dynamic_msi_routes and adding support for the proposed >> KVM_SIGNAL_MSI IOCTL. >> >> This series depends on "kvm: set gsi_bits and max_gsi correctly" >> (http://thread.gmane.org/gmane.comp.emulators.kvm.devel/88906). > > Looks good to me. > How hard would it be to add irqfd support? Shouldn't be, but the changes will be a bit bigger. I'm thinking about a revamped interface between the MSI core and affected devices for a while. Will try to put down in some lines of code what I have in mind - once the dynamic MSI injection topic has settled. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux