From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFAHX-00018l-RU for qemu-devel@nongnu.org; Tue, 03 Apr 2012 16:24:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFAHV-0006pF-Vd for qemu-devel@nongnu.org; Tue, 03 Apr 2012 16:24:47 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:38243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFAHV-0006nh-PK for qemu-devel@nongnu.org; Tue, 03 Apr 2012 16:24:45 -0400 Message-ID: <4F7B5C8A.8080502@weilnetz.de> Date: Tue, 03 Apr 2012 22:24:42 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1332236961-22743-1-git-send-email-pbonzini@redhat.com> <4F7AD9B7.30502@redhat.com> In-Reply-To: <4F7AD9B7.30502@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] fix w32 sockets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Blue Swirl , qemu-devel@nongnu.org Am 03.04.2012 13:06, schrieb Paolo Bonzini: > Il 20/03/2012 10:49, Paolo Bonzini ha scritto: >> The w32 main loop has been mostly broken by the introduction of the >> glib main loop. glib's g_poll does not use sockets on w32, so we >> need a separate approach. >> >> Patch 1 is a simple cleanup that is needed later in the series. >> >> Patch 2 and patch 3 completely separate the way the main loop waits >> on POSIX and w32 systems, and drop glib source handling from the w32 >> main loop. >> >> Patch 4 fixes a longstanding bug in how sockets are handled, also >> simplifying the code in the process. On top of this simplification, >> patch 5 starts using g_poll in the w32 main loop and patch 6 adds >> back glib source handling. >> >> I didn't test this in the conditions explained in bug 916720, but I >> tested both a TCP monitor and an stdio monitor and both work (under >> Wine that is). >> >> Stefan, can you please take care of shepherding the patches in >> (pinging etc.)? >> >> Paolo Bonzini (6): >> slirp: use socket_set_nonblock >> main loop: use msec-based timeout in glib_select_fill >> main-loop: disable fd_set-based glib integration under w32 >> main-loop: interrupt wait when data arrives on a socket >> main-loop: replace WaitForMultipleObjects with g_poll >> main-loop: integrate glib sources for w32 > > Patch 1 is now in separately through the slirp tree, so the other 5 can > now be applied. Blue, can you commit them? > > Paolo As I wrote in my last mail, these patches don't fix the main loop problem(s). Nevertheless I think that they improve the code in the right direction, therefore it's ok to commit them. Regards, Stefan