All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Seiffert <kaffeemonster@googlemail.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits
Date: Wed, 4 Apr 2012 00:26:25 +0200	[thread overview]
Message-ID: <4F7B7911.5090307@googlemail.com> (raw)
In-Reply-To: <20120403.180212.1644422418766062447.davem@davemloft.net>

David Miller schrieb:
> From: Jan Seiffert <kaffeemonster@googlemail.com>
> Date: Fri, 30 Mar 2012 17:08:19 +0200
> 
>> The function is renamed to make it a little more clear what it does.
>> It is not added to any .h because it is not for general consumption, only for
>> bpf internal use (and so by the jits).
>>
>> Signed-of-by: Jan Seiffert <kaffeemonster@googlemail.com>
> 
> Applied but with comment formatting fixed up:
> 
>> +/*
>> + * No hurry in this branch
>> + *
>> + * Exported for the bpf jit load helper.
>> + */
> 
> Like this:
> 
>> +/* No hurry in this branch
>> + *
>> + * Exported for the bpf jit load helper.
>> + */
> 

Thanks David!

I was planning on a V5 for the little things i did wrong (wrong patch
separator, etc.) but wanted to wait a little more for more feedback.

Is that the preferred comment style in net/ ? Coding style says
first line empty. Or just to match the rest of the file?

Greetings
	Jan

  reply	other threads:[~2012-04-03 22:26 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30 15:00 [REGRESSION][PATCH V4 0/3] bpf jit drops the ball on negative memory references Jan Seiffert
2012-03-30 15:00 ` Jan Seiffert
2012-03-30 15:08 ` [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits Jan Seiffert
2012-03-30 15:08   ` Jan Seiffert
2012-03-30 18:56   ` Eric Dumazet
2012-03-30 18:56     ` Eric Dumazet
2012-04-02  9:18   ` David Laight
2012-04-02  9:18     ` David Laight
2012-04-02 13:02     ` Jan Seiffert
2012-04-02 13:02       ` Jan Seiffert
2012-04-03 22:02   ` David Miller
2012-04-03 22:02     ` David Miller
2012-04-03 22:26     ` Jan Seiffert [this message]
2012-04-03 22:28       ` David Miller
2012-04-03 22:41         ` Jan Seiffert
2012-03-30 15:24 ` [REGRESSION][PATCH V4 2/3] bpf jit: Let the x86 jit handle negative offsets Jan Seiffert
2012-03-30 18:58   ` Eric Dumazet
2012-04-03 22:02   ` David Miller
2012-03-30 15:35 ` [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc " Jan Seiffert
2012-03-30 15:35   ` Jan Seiffert
2012-04-03 22:03   ` David Miller
2012-04-03 22:03     ` David Miller
2012-04-03 22:11     ` Benjamin Herrenschmidt
2012-04-03 22:11       ` Benjamin Herrenschmidt
2012-04-30  2:43       ` Benjamin Herrenschmidt
2012-04-30  3:40         ` Benjamin Herrenschmidt
2012-04-30  3:43         ` Jan Seiffert
2012-04-30  3:43           ` Jan Seiffert
2012-04-30  4:11         ` Benjamin Herrenschmidt
2012-04-30  4:27           ` Jan Seiffert
2012-04-30  4:27             ` Jan Seiffert
2012-04-30  4:29             ` Benjamin Herrenschmidt
2012-04-30  4:29               ` Benjamin Herrenschmidt
2012-04-30  4:43               ` Jan Seiffert
2012-04-30  4:43                 ` Jan Seiffert
2012-04-30  5:26                 ` Benjamin Herrenschmidt
2012-04-30  5:26                   ` Benjamin Herrenschmidt
2012-04-30 17:41                   ` David Miller
2012-04-30 21:55                     ` Benjamin Herrenschmidt
2012-04-30 21:57                       ` Benjamin Herrenschmidt
2012-04-30 22:32                         ` Jan Seiffert
2012-05-01  0:26                           ` Benjamin Herrenschmidt
2012-05-01  0:44                             ` Jan Seiffert
2012-05-01  0:47                               ` Benjamin Herrenschmidt
2012-05-01  1:03                             ` David Miller
2012-04-30  5:02           ` [REGRESSION][PATCH V5 " Jan Seiffert
2012-04-30  5:02             ` Jan Seiffert
2012-04-30 17:41             ` David Miller
2012-04-30 17:41               ` David Miller
2012-04-03 22:31     ` [REGRESSION][PATCH V4 " Jan Seiffert
2012-04-03 22:35       ` David Miller
2012-04-02 19:51 ` [PATCH V1 1/1] NET: add a bpf jit for Alpha Jan Seiffert
2012-04-02 19:51   ` Jan Seiffert
2012-04-02 20:43   ` Matt Turner
2012-04-02 21:04     ` Jan Seiffert
2012-04-02 21:04       ` Jan Seiffert
2012-04-04 14:27   ` Richard Henderson
2012-04-05  0:24     ` Jan Seiffert
2012-04-05  0:24       ` Jan Seiffert
2012-04-05  0:24       ` Jan Seiffert
2012-04-05  0:24       ` Jan Seiffert
2012-04-06 18:57 ` [REGRESSION][PATCH v1] bpf jit: Let the arm jit handle negative memory references Jan Seiffert
2012-04-06 21:48   ` [REGRESSION][PATCH v2] " Jan Seiffert
2012-04-06 22:28   ` [REGRESSION][PATCH v1] " Mircea Gherzan
2012-04-06 23:30     ` Jan Seiffert
2012-04-07  3:41     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7B7911.5090307@googlemail.com \
    --to=kaffeemonster@googlemail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.