All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Liu <jeff.liu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ben Myers <bpm@sgi.com>,
	Chandra Seetharaman <sekharan@us.ibm.com>,
	xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: don't fill statvfs with project quota for a directory if it was not enabled.
Date: Wed, 04 Apr 2012 16:02:41 +0800	[thread overview]
Message-ID: <4F7C0021.8000608@oracle.com> (raw)
In-Reply-To: <20120402163903.GA6425@infradead.org>

On 04/03/2012 12:39 AM, Christoph Hellwig wrote:

> On Sun, Apr 01, 2012 at 12:55:55PM +0800, Jeff Liu wrote:
>> Hello,
>>
>> I can trigger a BUG() at fs/xfs/xfs_dquot.c on vanilla kernel 3.3.0 by the following steps:
>>
>> 1. mount a XFS partition without 'pquota' option.
>>    /dev/sda7 on /xfs type xfs (rw)
>>
>> 2. setup project1 on it.
>>    $ cat /etc/projects 
>>    1:/xfs
>>    $ cat /etc/projid
>>    project1:1
>>    $ sudo xfs_quota -x -c 'project -s project1' /xfs
>>
>> 3. du -sh /xfs
> 
> Can you wire this up as a test case for xfstests?

Ok, I'll work it out.

Thanks,
-Jeff

> 
>> +		    ((mp->m_qflags & (XFS_PQUOTA_ACCT|XFS_OQUOTA_ENFD))) ==
>> +		     (XFS_PQUOTA_ACCT|XFS_OQUOTA_ENFD)) {
> 
> This check is supposed to return false.  I guess Chandras separate
> project quota inode preparations somehow broke it.
> 
> Chandra, can you look into this issue?
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2012-04-04  8:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-01  4:55 [PATCH] xfs: don't fill statvfs with project quota for a directory if it was not enabled Jeff Liu
2012-04-02 16:39 ` Christoph Hellwig
2012-04-02 18:36   ` Chandra Seetharaman
2012-04-04  8:02   ` Jeff Liu [this message]
2012-04-04 16:48   ` Chandra Seetharaman
2012-04-05  5:16     ` Jeff Liu
2012-04-05  7:31       ` Jeff Liu
2012-04-11 19:59 ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2012-04-12  3:59 sn0wing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7C0021.8000608@oracle.com \
    --to=jeff.liu@oracle.com \
    --cc=bpm@sgi.com \
    --cc=hch@infradead.org \
    --cc=sekharan@us.ibm.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.