All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] rpm: Fix automagic dependency on openssl
Date: Wed, 4 Apr 2012 10:15:25 +0100	[thread overview]
Message-ID: <4F7C112D.7080309@imgtec.com> (raw)
In-Reply-To: <87k41wv710.fsf@macbook.be.48ers.dk>

On 04/03/2012 10:29 PM, Peter Korsgaard wrote:

>>>>>> "Markos" == Markos Chandras <markos.chandras@imgtec.com> writes:
> 
>  Markos> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>  Markos> ---
>  Markos>  package/rpm/rpm.mk |    7 +++++++
>  Markos>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
>  Markos> diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
>  Markos> index 9f42ee1..47c2ee9 100644
>  Markos> --- a/package/rpm/rpm.mk
>  Markos> +++ b/package/rpm/rpm.mk
>  Markos> @@ -17,6 +17,13 @@ RPM_CONF_OPT = --disable-build-versionscript
> --disable-rpath \
>  Markos>        --with-libbeecrypt=$(STAGING_DIR) \
>  Markos>        --with-popt=$(STAGING_DIR)
> 
>  Markos> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
>  Markos> +RPM_DEPENDENCIES += openssl
>  Markos> +RPM_CONF_OPT += --with-openssl=external
>  Markos> +else
>  Markos> +RPM_CONF_OPT += --with-openssl=no
>  Markos> +endif
> 
> Hmm, this makes sense but BR2_PACKAGE_RPM selects
> BR2_PACKAGE_OPENSSL. Is openssl optional? If so, please drop the select
> line in Config.in.
> 
> --
> Bye, Peter Korsgaard
> 

Hi Peter,

You are right. All it needs is the --with-openssl=external switch in
RPM_CONF_OPT. I will send a new patch asap.

-- 
markos

      reply	other threads:[~2012-04-04  9:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-03  8:35 [Buildroot] [PATCH] rpm: Fix automagic dependency on openssl Markos Chandras
2012-04-03 21:29 ` Peter Korsgaard
2012-04-04  9:15   ` Markos Chandras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7C112D.7080309@imgtec.com \
    --to=markos.chandras@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.