From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:38863 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755807Ab2DDL7H (ORCPT ); Wed, 4 Apr 2012 07:59:07 -0400 Message-ID: <4F7C3787.5020602@iki.fi> Date: Wed, 04 Apr 2012 14:59:03 +0300 From: Antti Palosaari MIME-Version: 1.0 To: Gianluca Gennari CC: linux-media@vger.kernel.org, m@bues.ch, hfvogt@gmx.net, mchehab@redhat.com Subject: Re: [PATCH] af9035: add several new USB IDs References: <1333540034-14002-1-git-send-email-gennarone@gmail.com> In-Reply-To: <1333540034-14002-1-git-send-email-gennarone@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 04.04.2012 14:47, Gianluca Gennari wrote: > Add several new USB IDs extracted from the Windows and Linux drivers published > by the manufacturers (Terratec and AVerMedia). > + [AF9035_07CA_0867] = { > + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0867)}, > [AF9035_07CA_1867] = { > USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)}, > + [AF9035_07CA_3867] = { > + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_3867)}, > [AF9035_07CA_A867] = { > USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)}, > + [AF9035_07CA_B867] = { > + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B867)}, It have been common practise to use product names for USB PID definitions instead of USB ID numbers. I vote to continue that practise. Also, I am not very sure if it is wise to add new IDs without any testing. Likely those are just reference design and will work, but sometimes there is also some changes done for schematic wiring. Especially for Avermedia, see hacks needed some AF9015 Avermedia devices. They have put invalid data to eeprom and thus hacks are needed for overriding tuner IDs etc. Not to mention, driver supports also dynamic IDs and even device ID is missing user can load driver using dynamic ID and report it working or non-working. Anyone else any thoughts about adding IDs without testing ? regards Antti -- http://palosaari.fi/