From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45751)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SFSNH-0005Ht-K9
	for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:44:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SFSN5-0008Oc-Sf
	for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:43:53 -0400
Received: from goliath.siemens.de ([192.35.17.28]:26935)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SFSN5-0008NK-JD
	for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:43:43 -0400
Message-ID: <4F7C6C24.4060106@siemens.com>
Date: Wed, 04 Apr 2012 17:43:32 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <cover.1333552093.git.jan.kiszka@siemens.com>
	<4F7C663E.20200@redhat.com> <4F7C67BA.4000007@siemens.com>
	<4F7C68E2.508@redhat.com> <4F7C6AF9.7080605@siemens.com>
In-Reply-To: <4F7C6AF9.7080605@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading &
	locking API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2012-04-04 17:38, Jan Kiszka wrote:
> On 2012-04-04 17:29, Paolo Bonzini wrote:
>> Il 04/04/2012 17:24, Jan Kiszka ha scritto:
>>>>> For patches 3 and 4, I'd rather use an EventNotifier...
>>> ...which still lacks support for non-eventfd systems. Hmm, I guess it's
>>> time to consolidate both.
>>
>> Perhaps you can take the relevant patches out of the thread-blocks
>> branch at git://github.com/pbonzini/qemu.git?  The iothread eventfd
>> could also use an EventNotifier.
> 
> Current EventNotifier code applies EFD_SEMAPHORE, which is not what we
> want for Posix AIO (otherwise we could just stick with the pipe). I
> cannot match the reasoning for EFD_SEM in event_notifier.c with the man
> page, need to dig deeper.

Err, non-sense, comment and code diverged and confused my eyes...

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux