From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44429)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien.grall@citrix.com>) id 1SFSYo-0008Vh-8P
	for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:55:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <julien.grall@citrix.com>) id 1SFSYm-0003CT-45
	for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:55:49 -0400
Received: from smtp.citrix.com ([66.165.176.89]:26990)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien.grall@citrix.com>) id 1SFSYl-0003Bo-Uy
	for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:55:48 -0400
Message-ID: <4F7C6F0D.4000203@citrix.com>
Date: Wed, 4 Apr 2012 16:55:57 +0100
From: Julien Grall <julien.grall@citrix.com>
MIME-Version: 1.0
References: <a6fb7184d69364f152ef03df0e73070c0b43a77c.1333377087.git.julien.grall@citrix.com>
	<4F7AAC02.6090606@redhat.com>
In-Reply-To: <4F7AAC02.6090606@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Memory: unify ioport registration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Julian Pidancet <julian.pidancet@citrix.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>

On 04/03/2012 08:51 AM, Avi Kivity wrote:
> On 04/02/2012 05:37 PM, Julien Grall wrote:
>    
>>       s = g_malloc0(sizeof(SerialState));
>>
>> @@ -820,8 +828,9 @@ SerialState *serial_init(int base, qemu_irq irq, int baudbase,
>>
>>       vmstate_register(NULL, base,&vmstate_serial, s);
>>
>> -    register_ioport_write(base, 8, 1, serial_ioport_write, s);
>> -    register_ioport_read(base, 8, 1, serial_ioport_read, s);
>> +    portio_list_init(serial_port_list, serial_portio_list, s, "serial-io");
>> +    portio_list_add(serial_port_list, get_system_io(), base);
>> +
>>      
> Should we just remove serial_init() and replace it with the serial-isa
> QOM class?
>    
After few researchs, it's seems this function is not used in the
source code. Is that right ?