All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Kees Cook <keescook@chromium.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
	linux-kernel@vger.kernel.org, PhillipLougherplougher@redhat.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <greg@kroah.com>,
	Dan Rosenberg <drosenberg@vsecurity.com>,
	Eugene Teo <eteo@redhat.com>, Eric Paris <eparis@redhat.com>,
	James Morris <jmorris@namei.org>
Subject: Re: [PATCH] sysctl: fix write access to dmesg_restrict/kptr_restrict
Date: Wed, 04 Apr 2012 21:07:03 +0200	[thread overview]
Message-ID: <4F7C9BD7.8000604@nod.at> (raw)
In-Reply-To: <20120404184019.GA32681@www.outflux.net>

On 04.04.2012 20:40, Kees Cook wrote:
> Commit bfdc0b4 adds code to restrict access to dmesg_restrict,
> however, it incorrectly alters kptr_restrict rather than
> dmesg_restrict.
>
> The original patch from Richard Weinberger
> (https://lkml.org/lkml/2011/3/14/362) alters dmesg_restrict as
> expected, and so the patch seems to have been misapplied.
>
> This adds the CAP_SYS_ADMIN check to both dmesg_restrict and
> kptr_restrict, since both are sensitive.
>
> Reported-by: Phillip Lougher<plougher@redhat.com>
> Signed-off-by: Kees Cook<keescook@chromium.org>
> Cc: stable@vger.kernel.org

Acked-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

  reply	other threads:[~2012-04-04 19:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30 23:43 [PATCH] sysctl: fix restrict write access to dmesg_restrict Phillip Lougher
2012-03-30 23:50 ` Richard Weinberger
2012-03-31  0:55   ` Andrew Morton
2012-03-31  1:58     ` Phillip Lougher
2012-03-31 16:13       ` Greg Kroah-Hartman
2012-04-01  2:10 ` Kees Cook
2012-04-04  2:30   ` Serge E. Hallyn
2012-04-04 18:40     ` [PATCH] sysctl: fix write access to dmesg_restrict/kptr_restrict Kees Cook
2012-04-04 19:07       ` Richard Weinberger [this message]
2012-04-04 21:27       ` Serge E. Hallyn
2012-04-04 21:43         ` Kees Cook
2012-04-05  5:11       ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7C9BD7.8000604@nod.at \
    --to=richard@nod.at \
    --cc=PhillipLougherplougher@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=drosenberg@vsecurity.com \
    --cc=eparis@redhat.com \
    --cc=eteo@redhat.com \
    --cc=greg@kroah.com \
    --cc=jmorris@namei.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.