From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Update comment for clk_round_rate()
Date: Thu, 5 Apr 2012 10:41:58 +0530 [thread overview]
Message-ID: <4F7D299E.1050307@st.com> (raw)
In-Reply-To: <CAJOA=zOPn0FcwO0McSb8-18h7LiJndRD2nmCCvxUEEm+fakvKg@mail.gmail.com>
On 4/4/2012 11:37 PM, Turquette, Mike wrote:
> The common clk framework doesn't enforce any policy like this, nor do
> I think it should. The clk framework is far from complete and I
> wouldn't be surprised if we see folks who want their rounded rate to
> represent a minimum value (instead of a maximum as your patch states).
Ok. Just for example, suppose foo_clk can have following rates:
100, 110, 120, 130, 140.
And we call round_rate with a value of 126.
Now i can't visualize why would anybody want it to return 130 (above the
limits requested)? I agree both 100 and 120 can be returned, based on
your below logic.
> This might be achieved later on by a platform-specific or
> framework-wide flag, similar to how CPUfreq does it today
> (CPUFREQ_RELATION_L and CPUFREQ_RELATION_H).
>
> Thank you for submitting the patch, but for now it's a NACK.
No Probs.
--
viresh
next prev parent reply other threads:[~2012-04-05 5:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 17:27 [PATCH] clk: Update comment for clk_round_rate() viresh kumar
2012-04-04 18:07 ` Turquette, Mike
2012-04-05 5:11 ` Viresh Kumar [this message]
2012-04-05 7:03 ` Uwe Kleine-König
2012-04-05 7:07 ` Viresh Kumar
2012-04-05 7:26 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7D299E.1050307@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.