From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57188)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1SFjKs-0008EY-C3
	for qemu-devel@nongnu.org; Thu, 05 Apr 2012 05:50:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1SFjKj-0006Aw-Gx
	for qemu-devel@nongnu.org; Thu, 05 Apr 2012 05:50:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48730)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1SFjKj-0006AD-90
	for qemu-devel@nongnu.org; Thu, 05 Apr 2012 05:50:25 -0400
Message-ID: <4F7D6AD1.9040601@redhat.com>
Date: Thu, 05 Apr 2012 12:50:09 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <cover.1333561077.git.julien.grall@citrix.com>
	<bba19b27c9f06b384aac6a270df980c51f7ed608.1333561077.git.julien.grall@citrix.com>
In-Reply-To: <bba19b27c9f06b384aac6a270df980c51f7ed608.1333561077.git.julien.grall@citrix.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2 2/7] hw/acpi_piix4.c: replace
	register_ioport*
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Julien Grall <julien.grall@citrix.com>
Cc: julian.pidancet@citrix.com, qemu-devel@nongnu.org, Stefano.Stabellini@eu.citrix.com

On 04/04/2012 09:21 PM, Julien Grall wrote:
> This patch replaces all register_ioport* with portio_*. It permits to
> use the new Memory stuff like listener.
>
>
>  
> +static const MemoryRegionPortio piix4_portio_list[] = {
> +    { 0x00, 64, 1, .read = smb_ioport_readb, }, /* s->smb_io_base */
> +    { 0x00, 64, 1, .write = smb_ioport_writeb, }, /* s->smb_io_base */
> +    PORTIO_END_OF_LIST(),
> +};
> +
> +static const MemoryRegionPortio acpi_portio_list[] = {
> +    { 0x00, 4, 4, .write = acpi_dbg_writel, }, /* ACPI_DBG_IO_ADDR */
> +    PORTIO_END_OF_LIST(),
> +};

Please replace single-port lists with MemoryRegionOps (and MemoryRegions
in the state structure).  I think I mentioned this in the first review,
but perhaps only about a single instance, sorry.

-- 
error compiling committee.c: too many arguments to function