From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH 2/4] drm/exynos: remove unused codes in hdmi and mixer driver Date: Thu, 05 Apr 2012 19:53:43 +0900 Message-ID: <4F7D79B7.6010201@samsung.com> References: <1333621432-13316-1-git-send-email-jy0922.shim@samsung.com> <1333621432-13316-3-git-send-email-jy0922.shim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id C687A9E754 for ; Thu, 5 Apr 2012 03:53:42 -0700 (PDT) Received: from epcpsbgm1.samsung.com (mailout2.samsung.com [203.254.224.25]) by mailout2.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0M2000HDX68EPDB0@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 05 Apr 2012 19:53:41 +0900 (KST) Received: from [165.213.219.123] by mmp1.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTPA id <0M2000GCP69H7E00@mmp1.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 05 Apr 2012 19:53:41 +0900 (KST) In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: "Semwal, Sumit" Cc: inki.dae@samsung.com, kyungmin.park@samsung.com, sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 04/05/2012 07:38 PM, Semwal, Sumit wrote: > Hi Joonyoung, > > On Thu, Apr 5, 2012 at 3:53 PM, Joonyoung Shim wrote: >> Some defines and members in struct mixer_context aren't used, remove >> them. >> >> Signed-off-by: Joonyoung Shim >> Signed-off-by: Kyungmin Park >> --- >> drivers/gpu/drm/exynos/exynos_hdmi.c | 1 - >> drivers/gpu/drm/exynos/exynos_mixer.c | 21 +++++++++------------ >> 2 files changed, 9 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c >> index 0a71317..340424f 100644 >> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c >> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c >> @@ -40,7 +40,6 @@ >> >> #include "exynos_hdmi.h" >> >> -#define HDMI_OVERLAY_NUMBER 3 >> #define MAX_WIDTH 1920 >> #define MAX_HEIGHT 1080 >> #define get_hdmi_context(dev) platform_get_drvdata(to_platform_device(dev)) >> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c >> index 495a7af..563092e 100644 >> --- a/drivers/gpu/drm/exynos/exynos_mixer.c >> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c >> @@ -37,7 +37,8 @@ >> #include "exynos_drm_drv.h" >> #include "exynos_drm_hdmi.h" >> >> -#define HDMI_OVERLAY_NUMBER 3 >> +#define MIXER_WIN_NR 3 >> +#define MIXER_DEFAULT_WIN 0 > Patch description says 'remove unused codes...', but looks like you're > adding more codes here? I think you should do the addition / deletion > in separate patches. "remove unused codes" is incorrect a bit, but please think this is just code cleanup to remove unnecessary codes. Thanks. >> #define get_mixer_context(dev) platform_get_drvdata(to_platform_device(dev)) >> >> @@ -75,16 +76,12 @@ struct mixer_resources { >> }; >> >> struct mixer_context { >> - struct fb_videomode *default_timing; >> - unsigned int default_win; >> - unsigned int default_bpp; >> unsigned int irq; >> int pipe; >> bool interlace; >> - bool vp_enabled; >> >> struct mixer_resources mixer_res; >> - struct hdmi_win_data win_data[HDMI_OVERLAY_NUMBER]; >> + struct hdmi_win_data win_data[MIXER_WIN_NR]; >> }; >> >> static const u8 filter_y_horiz_tap8[] = { >> @@ -643,9 +640,9 @@ static void mixer_win_mode_set(void *ctx, >> >> win = overlay->zpos; >> if (win == DEFAULT_ZPOS) >> - win = mixer_ctx->default_win; >> + win = MIXER_DEFAULT_WIN; >> >> - if (win< 0 || win> HDMI_OVERLAY_NUMBER) { >> + if (win< 0 || win> MIXER_WIN_NR) { >> DRM_ERROR("overlay plane[%d] is wrong\n", win); >> return; >> } >> @@ -683,9 +680,9 @@ static void mixer_win_commit(void *ctx, int zpos) >> DRM_DEBUG_KMS("[%d] %s, win: %d\n", __LINE__, __func__, win); >> >> if (win == DEFAULT_ZPOS) >> - win = mixer_ctx->default_win; >> + win = MIXER_DEFAULT_WIN; >> >> - if (win< 0 || win> HDMI_OVERLAY_NUMBER) { >> + if (win< 0 || win> MIXER_WIN_NR) { >> DRM_ERROR("overlay plane[%d] is wrong\n", win); >> return; >> } >> @@ -706,9 +703,9 @@ static void mixer_win_disable(void *ctx, int zpos) >> DRM_DEBUG_KMS("[%d] %s, win: %d\n", __LINE__, __func__, win); >> >> if (win == DEFAULT_ZPOS) >> - win = mixer_ctx->default_win; >> + win = MIXER_DEFAULT_WIN; >> >> - if (win< 0 || win> HDMI_OVERLAY_NUMBER) { >> + if (win< 0 || win> MIXER_WIN_NR) { >> DRM_ERROR("overlay plane[%d] is wrong\n", win); >> return; >> } >> -- >> 1.7.5.4 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel > Best regards, > ~Sumit. >