From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH 2/4] drm/exynos: remove unused codes in hdmi and mixer driver Date: Thu, 05 Apr 2012 20:02:05 +0900 Message-ID: <4F7D7BAD.4060407@samsung.com> References: <1333621432-13316-1-git-send-email-jy0922.shim@samsung.com> <1333621432-13316-3-git-send-email-jy0922.shim@samsung.com> <4F7D79B7.6010201@samsung.com> <20120405110011.GC4291@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id BF3859E889 for ; Thu, 5 Apr 2012 04:02:05 -0700 (PDT) Received: from epcpsbgm2.samsung.com (mailout1.samsung.com [203.254.224.24]) by mailout1.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0M200063E6NGU301@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 05 Apr 2012 20:02:04 +0900 (KST) Received: from [165.213.219.123] by mmp1.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTPA id <0M2000DUI6NFYL70@mmp1.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 05 Apr 2012 20:02:03 +0900 (KST) In-reply-to: <20120405110011.GC4291@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: inki.dae@samsung.com, kyungmin.park@samsung.com, sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 04/05/2012 08:00 PM, Daniel Vetter wrote: > On Thu, Apr 05, 2012 at 07:53:43PM +0900, Joonyoung Shim wrote: >> On 04/05/2012 07:38 PM, Semwal, Sumit wrote: >>> Hi Joonyoung, >>> >>> On Thu, Apr 5, 2012 at 3:53 PM, Joonyoung Shim wrote: >>>> Some defines and members in struct mixer_context aren't used, remove >>>> them. >>>> >>>> Signed-off-by: Joonyoung Shim >>>> Signed-off-by: Kyungmin Park >>>> --- >>>> drivers/gpu/drm/exynos/exynos_hdmi.c | 1 - >>>> drivers/gpu/drm/exynos/exynos_mixer.c | 21 +++++++++------------ >>>> 2 files changed, 9 insertions(+), 13 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c >>>> index 0a71317..340424f 100644 >>>> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c >>>> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c >>>> @@ -40,7 +40,6 @@ >>>> >>>> #include "exynos_hdmi.h" >>>> >>>> -#define HDMI_OVERLAY_NUMBER 3 >>>> #define MAX_WIDTH 1920 >>>> #define MAX_HEIGHT 1080 >>>> #define get_hdmi_context(dev) platform_get_drvdata(to_platform_device(dev)) >>>> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c >>>> index 495a7af..563092e 100644 >>>> --- a/drivers/gpu/drm/exynos/exynos_mixer.c >>>> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c >>>> @@ -37,7 +37,8 @@ >>>> #include "exynos_drm_drv.h" >>>> #include "exynos_drm_hdmi.h" >>>> >>>> -#define HDMI_OVERLAY_NUMBER 3 >>>> +#define MIXER_WIN_NR 3 >>>> +#define MIXER_DEFAULT_WIN 0 >>> Patch description says 'remove unused codes...', but looks like you're >>> adding more codes here? I think you should do the addition / deletion >>> in separate patches. >> "remove unused codes" is incorrect a bit, but please think this is just code >> cleanup to remove unnecessary codes. > Commit messages that flat-out lie in this way are bad. You need to at > least mention what additional stuff you're doing in the commit message, > besides removing unused code. Or split the patch up as Sumit suggested. > OK, i will do it. Thanks.