From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amir Vadai Subject: Re: [PATCH net-next V7 0/8] net/mlx4_en: DCB QoS support Date: Thu, 5 Apr 2012 14:22:16 +0300 Message-ID: <4F7D8068.1000100@mellanox.com> References: <1333611211-1032-1-git-send-email-amirv@mellanox.com> <20120405.052828.1474884969422039237.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , , , To: David Miller , , Return-path: Received: from eu1sys200aog112.obsmtp.com ([207.126.144.133]:59801 "HELO eu1sys200aog112.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751218Ab2DEL2E (ORCPT ); Thu, 5 Apr 2012 07:28:04 -0400 In-Reply-To: <20120405.052828.1474884969422039237.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On 04/05/2012 12:28 PM, David Miller wrote: > From: Amir Vadai > Date: Thu, 5 Apr 2012 10:33:23 +0300 > >> DCBX version 802.1qaz is supported. >> User Priority (UP) is set in QP context instead of in WQE (QP Work Queue >> Element), which means that all traffic from a queue will have the same UP. >> UP is also set for untagged traffic to be able to classify such traffic too. >> >> Mapping from sk_prio to User Priority is done by sch_mqprio mapping. Although >> confusingly sch_mqprio maps sk_prio to something called TC, it is not related >> to DCBX's TC, and is interpreted by mlx4_en driver as UP. >> >> User can set maximal BW for an ETS TC. This could be done by a new optional >> attribute added to DCB_ATTR_IEEE called DCBNL DCB_ATTR_IEEE_MAXRATE. It accept >> an array of 8 64 bits values, 1 for every ETS TC. Units are in Kbps. > > All applied, thanks. > > Please double check that all the new locations that reference > ip_tos2prio have a proper dependency on CONFIG_INET. > > THanks. Thank you and to the reviewers. And Yes, the dependencies are good: The only new place that uses it is in cma.c which is part of rdma_cm. rdma_cm depends on CONFIG_INFINIBAND_ADDR_TRANS that depends on CONFIG_INET - Amir