-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/04/2012 09:10 PM, Dmitry Torokhov wrote: [suggestions for my patch] Based on your input I have prepared two patches which might be easier to review than the complete diff. The first one is IMHO pretty straightforward and implements most of the small bits. The second one sits on top of the first one and is an attempt at more generic attribute handling. I must say that I am not too happy about it, but maybe I am thinking too convoluted here. It saves about 3 lines of code and exchanges a lot of easy and straightforward code with stuff that is harder to follow - especially the lookup of the matching attribute makes me unhappy. There are bits in it I like and will probably use. But the lookup... any suggestions are welcome. Bye, Simon - -- Simon Budig kernel concepts GmbH simon.budig@kernelconcepts.de Sieghuetter Hauptweg 48 +49-271-771091-17 D-57072 Siegen -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk99lfoACgkQO2O/RXesiHAE6gCgw2EK5b6MKzfYY7ekEwdNy4FG GlUAn2db538XupC6i7OZoP06Zb+RFaBI =UTET -----END PGP SIGNATURE-----