From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: set idle_bias_off=1 for all platform DAPM contexts
Date: Thu, 05 Apr 2012 12:34:22 -0600 [thread overview]
Message-ID: <4F7DE5AE.3060805@wwwdotorg.org> (raw)
In-Reply-To: <1333650481-19469-1-git-send-email-swarren@wwwdotorg.org>
On 04/05/2012 12:28 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The ASoC core currently defaults to using STANDBY rather than OFF for
> idle ASoC platform devices, which causes a permanent pm_runtime_get() on
> them. This keeps the device active unnecessarily. This can be especially
> problematic when the ASoC platform device and DAI device are the same
> device.
>
> The distinction between OFF and STANDBY is likely not relevant for ASoC
> platform drivers, since they aren't analog devices. So, solve this issue
> by hard-coding idle_bias_off = 1 for all ASoC platform devices. If this
> turns out to be a problem, this value could be sourced from the
> snd_soc_platform_driver, similarly to soc_probe_codec().
Sorry, I forgot to mention that future Tegra ASoC changes will depend on
this change at runtime for correct operation.
next prev parent reply other threads:[~2012-04-05 18:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 18:28 [PATCH] ASoC: set idle_bias_off=1 for all platform DAPM contexts Stephen Warren
2012-04-05 18:34 ` Stephen Warren [this message]
2012-04-05 20:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7DE5AE.3060805@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.