From: Antti Palosaari <crope@iki.fi>
To: Gianluca Gennari <gennarone@gmail.com>
Cc: linux-media@vger.kernel.org, m@bues.ch, hfvogt@gmx.net,
mchehab@redhat.com
Subject: Re: [PATCH] af9033: implement get_frontend
Date: Fri, 06 Apr 2012 02:52:50 +0300 [thread overview]
Message-ID: <4F7E3052.1050907@iki.fi> (raw)
In-Reply-To: <1333644439-1875-1-git-send-email-gennarone@gmail.com>
On 05.04.2012 19:47, Gianluca Gennari wrote:
> Implement the get_frontend function.
> + struct dtv_frontend_properties *p =&fe->dtv_property_cache;
Commonly dtv_property_cache pointer is shorten as a letter c (cache) in
all demod drivers and old dvb_frontend_parameters used earlier was letter p.
> + p->inversion = INVERSION_AUTO;
> + p->frequency = state->frequency;
Fake resolving parameters is not appropriate as I understand. We should
just return parameters we can read from the hardware and not to guess
nor default some auto value.
I will applied that and make some changes as I explained.
http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/af9035_experimental
regards
Antti
--
http://palosaari.fi/
prev parent reply other threads:[~2012-04-05 23:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 16:47 [PATCH] af9033: implement get_frontend Gianluca Gennari
2012-04-05 23:52 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7E3052.1050907@iki.fi \
--to=crope@iki.fi \
--cc=gennarone@gmail.com \
--cc=hfvogt@gmx.net \
--cc=linux-media@vger.kernel.org \
--cc=m@bues.ch \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.