From: Donghwa Lee <dh09.lee@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/7] EXYNOS: support TRATS board display function
Date: Fri, 06 Apr 2012 13:09:31 +0900 [thread overview]
Message-ID: <4F7E6C7B.10802@samsung.com> (raw)
In-Reply-To: <20120406014429.74d941da@wker>
Thank you for your comment.
I will fix all this patch according to your comments and send version2.
Thank you,
Donghwa Lee
On Fri, 06 Apr 2012 08:44, Anatolij Gustschin wrote:
> Hi,
>
> On Thu, 05 Apr 2012 15:29:34 +0900
> Donghwa Lee <dh09.lee@samsung.com> wrote:
>
>> This patch support TRATS board configuration and display function.
>>
>> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>> ---
>> board/samsung/trats/trats.c | 147 +++++++++++++++++++++++++++++++++++++++++++
>> include/configs/trats.h | 8 +++
>> 2 files changed, 155 insertions(+), 0 deletions(-)
>>
>> diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
>> index a7b4e4a..a6861e1 100644
>> --- a/board/samsung/trats/trats.c
>> +++ b/board/samsung/trats/trats.c
> ...
>> @@ -22,12 +23,15 @@
>> * MA 02111-1307 USA
>> */
>>
>> +#include <lcd.h>
>
> Please put this lcd.h include after '#include <common.h>'. Otherwise the
> code is broken. lcd.h expects some macros defined elsewhere and these
> definitions will be included in common.h.
>
>> #include <common.h>
>
> Thanks,
> Anatolij
>
prev parent reply other threads:[~2012-04-06 4:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 6:29 [U-Boot] [PATCH 7/7] EXYNOS: support TRATS board display function Donghwa Lee
2012-04-05 23:44 ` Anatolij Gustschin
2012-04-06 4:09 ` Donghwa Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7E6C7B.10802@samsung.com \
--to=dh09.lee@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.