All of lore.kernel.org
 help / color / mirror / Atom feed
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kirkwood: add missing kexec.h include
Date: Fri, 06 Apr 2012 16:50:54 +0400	[thread overview]
Message-ID: <4F7EE6AE.4020909@mvista.com> (raw)
In-Reply-To: <1333715458-13834-1-git-send-email-ijc@hellion.org.uk>

On 06.04.2012 16:30, Ian Campbell wrote:
> Fixes build the following error when CONFIG_KEXEC is enabled:

    Maybe "the following build error" instead?

>    CC      arch/arm/mach-kirkwood/board-dt.o
> arch/arm/mach-kirkwood/board-dt.c: In function 'kirkwood_dt_init':
> arch/arm/mach-kirkwood/board-dt.c:52:2: error: 'kexec_reinit' undeclared (first use in this function)
> arch/arm/mach-kirkwood/board-dt.c:52:2: note: each undeclared identifier is reported only once for each function it appears in

> kexec.h also needs string.h.

    Why it doesn't include it?

> Signed-off-by: Ian Campbell<ijc@hellion.org.uk>
> ---
>   arch/arm/mach-kirkwood/board-dt.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-kirkwood/board-dt.c b/arch/arm/mach-kirkwood/board-dt.c
> index 1c672d9..5868b71 100644
> --- a/arch/arm/mach-kirkwood/board-dt.c
> +++ b/arch/arm/mach-kirkwood/board-dt.c
> @@ -14,6 +14,8 @@
>   #include<linux/init.h>
>   #include<linux/of.h>
>   #include<linux/of_platform.h>
> +#include<linux/string.h>
> +#include<asm/kexec.h>
>   #include<asm/mach/arch.h>
>   #include<asm/mach/map.h>
>   #include<mach/bridge-regs.h>

WBR, Sergei

  reply	other threads:[~2012-04-06 12:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-06 12:30 [PATCH] ARM: kirkwood: add missing kexec.h include Ian Campbell
2012-04-06 12:50 ` Sergei Shtylyov [this message]
2012-04-06 13:10   ` Ian Campbell
2012-04-06 17:45     ` Sergei Shtylyov
2012-04-06 18:32       ` Ian Campbell
2012-04-10 10:00     ` Russell King - ARM Linux
2012-04-10 10:27       ` Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2012-04-29 13:40 Ian Campbell
2012-04-29 13:40 ` Ian Campbell
2012-04-30 14:21 ` Arnd Bergmann
2012-04-30 14:21   ` Arnd Bergmann
2012-05-08 18:20   ` Jason Cooper
2012-05-08 18:20     ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7EE6AE.4020909@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.