All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fredrick <fjohnber@zoho.com>
To: netdev@vger.kernel.org
Cc: eric.dumazet@gmail.com
Subject: yield() in netlink_broadcast_filtered
Date: Fri, 06 Apr 2012 07:11:56 -0700	[thread overview]
Message-ID: <4F7EF9AC.8050305@zoho.com> (raw)



I see there is a yield being called from
netlink_broadcast_filtered.
.....
int netlink_broadcast_filtered(...)
{
....
         if (info.delivered) {
                 if (info.congested && (allocation & __GFP_WAIT))
                         yield();
                 return 0;
         }
         return -ESRCH;
}
.....

But I don't see the point of calling it.
After the yield, there is nothing being done.
It just returns. So why yield ?
Why can't it simply return?


-Fredrick

             reply	other threads:[~2012-04-06 14:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-06 14:11 Fredrick [this message]
2012-04-06 15:05 ` yield() in netlink_broadcast_filtered Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7EF9AC.8050305@zoho.com \
    --to=fjohnber@zoho.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.