From: David Ahern <dsahern@gmail.com>
To: Kant <fnord.hammer@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: perf report -k kfoo -C bar (3.2.14) crashes
Date: Fri, 06 Apr 2012 08:59:13 -0600 [thread overview]
Message-ID: <4F7F04C1.6090007@gmail.com> (raw)
In-Reply-To: <CAEmqk_wOgktquxBmMUyW1EskHOrca0n3OLnFp3yEk5UHPM0nHg@mail.gmail.com>
On 4/6/12 5:36 AM, Kant wrote:
> (gdb) bt
> #0 0x000000000041adb0 in __cmd_report () at builtin-report.c:315
> #1 cmd_report (argc=<optimized out>, argv=<optimized out>,
> prefix=<optimized out>) at builtin-report.c:575
> #2 0x000000000041129f in run_builtin (p=p@entry=0x6aab88,
> argc=argc@entry=6, argv=argv@entry=0x7e2c43b8e760) at perf.c:286
> #3 0x0000000000410b2f in handle_internal_command
> (argv=0x7e2c43b8e760, argc=6) at perf.c:358
> #4 run_argv (argv=0x7e2c43b8e560, argcp=0x7e2c43b8e56c) at perf.c:402
> #5 main (argc=6, argv=0x7e2c43b8e760) at perf.c:512
> --
> To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Fixed by 47fbe53bef3b219a365ebf3eca949d6cd4c5291c.I guess that one did
not make it into 3.2 stable.
Here's the diff if you want to apply it to your branch:
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 85c1e6b7..0f4555c 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1333,6 +1333,10 @@ int perf_session__cpu_bitmap(struct perf_session
*session,
}
map = cpu_map__new(cpu_list);
+ if (map == NULL) {
+ pr_err("Invalid cpu_list\n");
+ return -1;
+ }
for (i = 0; i < map->nr; i++) {
int cpu = map->map[i];
David
prev parent reply other threads:[~2012-04-06 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 11:36 perf report -k kfoo -C bar (3.2.14) crashes Kant
2012-04-06 14:59 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7F04C1.6090007@gmail.com \
--to=dsahern@gmail.com \
--cc=fnord.hammer@gmail.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.