From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCHv2 0/5] coupled cpuidle state support Date: Mon, 09 Apr 2012 12:41:39 +0530 Message-ID: <4F828BAB.5010302@ti.com> References: <1331749794-8056-1-git-send-email-ccross@android.com> <4F75ACCA.4090009@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F75ACCA.4090009@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Colin Cross Cc: Kevin Hilman , Len Brown , Kay Sievers , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Amit Kucheria , linux-pm@lists.linux-foundation.org, Arjan van de Ven , Rob Lee , linux-arm-kernel@lists.infradead.org List-Id: linux-pm@vger.kernel.org On Friday 30 March 2012 06:23 PM, Santosh Shilimkar wrote: > Colin, > > On Friday 16 March 2012 05:07 AM, Colin Cross wrote: >> On Wed, Mar 14, 2012 at 11:29 AM, Colin Cross wrote: > > [...] > >>> >>> v2: >>> * removed the coupled lock, replacing it with atomic counters >>> * added a check for outstanding pokes before beginning the >>> final transition to avoid extra wakeups >>> * made the cpuidle_coupled struct completely private >>> * fixed kerneldoc comment formatting >>> * added a patch with a helper function for resynchronizing >>> cpus after aborting idle >>> * added a patch (not for merging) to add trace events for >>> verification and performance testing >> >> I forgot to mention, this patch series is on v3.3-rc7, and will >> conflict with the cpuidle timekeeping patches. If those go in first >> (which is likely), I will rework this series on top of it. I left it >> on v3.3-rc7 now to make testing easier. > > I have re-based your series against Len Browns > next branch [1] which has time keeping and other cpuidle patches. > Have also folded the CPU hotplug fix which I posted in the > original coupled idle patch. > As you know, we have been playing around this series for OMAP for last few weeks. This version series seems to work as intended and found it pretty stable in my testing. Apart from the cpu hotplug fix and the trace event comment, series looks fine to me. FWIW, Reviewed-by: Santosh Shilimkar Tested-by: Santosh Shilimkar An updated version of this series along with OMAP cpuidle driver updates against 3.4-rc2 is available here [1] in case some body is interested looking at it. Regards Santosh [1] git://gitorious.org/omap-sw-develoment/linux-omap-dev.git for_3.5/coupled_cpuidle-rebase From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Mon, 09 Apr 2012 12:41:39 +0530 Subject: [PATCHv2 0/5] coupled cpuidle state support In-Reply-To: <4F75ACCA.4090009@ti.com> References: <1331749794-8056-1-git-send-email-ccross@android.com> <4F75ACCA.4090009@ti.com> Message-ID: <4F828BAB.5010302@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 30 March 2012 06:23 PM, Santosh Shilimkar wrote: > Colin, > > On Friday 16 March 2012 05:07 AM, Colin Cross wrote: >> On Wed, Mar 14, 2012 at 11:29 AM, Colin Cross wrote: > > [...] > >>> >>> v2: >>> * removed the coupled lock, replacing it with atomic counters >>> * added a check for outstanding pokes before beginning the >>> final transition to avoid extra wakeups >>> * made the cpuidle_coupled struct completely private >>> * fixed kerneldoc comment formatting >>> * added a patch with a helper function for resynchronizing >>> cpus after aborting idle >>> * added a patch (not for merging) to add trace events for >>> verification and performance testing >> >> I forgot to mention, this patch series is on v3.3-rc7, and will >> conflict with the cpuidle timekeeping patches. If those go in first >> (which is likely), I will rework this series on top of it. I left it >> on v3.3-rc7 now to make testing easier. > > I have re-based your series against Len Browns > next branch [1] which has time keeping and other cpuidle patches. > Have also folded the CPU hotplug fix which I posted in the > original coupled idle patch. > As you know, we have been playing around this series for OMAP for last few weeks. This version series seems to work as intended and found it pretty stable in my testing. Apart from the cpu hotplug fix and the trace event comment, series looks fine to me. FWIW, Reviewed-by: Santosh Shilimkar Tested-by: Santosh Shilimkar An updated version of this series along with OMAP cpuidle driver updates against 3.4-rc2 is available here [1] in case some body is interested looking at it. Regards Santosh [1] git://gitorious.org/omap-sw-develoment/linux-omap-dev.git for_3.5/coupled_cpuidle-rebase From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753953Ab2DIHR1 (ORCPT ); Mon, 9 Apr 2012 03:17:27 -0400 Received: from na3sys009aog118.obsmtp.com ([74.125.149.244]:42504 "EHLO na3sys009aog118.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752292Ab2DIHR0 (ORCPT ); Mon, 9 Apr 2012 03:17:26 -0400 Message-ID: <4F828BAB.5010302@ti.com> Date: Mon, 09 Apr 2012 12:41:39 +0530 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Colin Cross CC: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@lists.linux-foundation.org, Kevin Hilman , Len Brown , Trinabh Gupta , Arjan van de Ven , Deepthi Dharwar , Greg Kroah-Hartman , Kay Sievers , Daniel Lezcano , Amit Kucheria , Lorenzo Pieralisi , Rob Lee Subject: Re: [PATCHv2 0/5] coupled cpuidle state support References: <1331749794-8056-1-git-send-email-ccross@android.com> <4F75ACCA.4090009@ti.com> In-Reply-To: <4F75ACCA.4090009@ti.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 30 March 2012 06:23 PM, Santosh Shilimkar wrote: > Colin, > > On Friday 16 March 2012 05:07 AM, Colin Cross wrote: >> On Wed, Mar 14, 2012 at 11:29 AM, Colin Cross wrote: > > [...] > >>> >>> v2: >>> * removed the coupled lock, replacing it with atomic counters >>> * added a check for outstanding pokes before beginning the >>> final transition to avoid extra wakeups >>> * made the cpuidle_coupled struct completely private >>> * fixed kerneldoc comment formatting >>> * added a patch with a helper function for resynchronizing >>> cpus after aborting idle >>> * added a patch (not for merging) to add trace events for >>> verification and performance testing >> >> I forgot to mention, this patch series is on v3.3-rc7, and will >> conflict with the cpuidle timekeeping patches. If those go in first >> (which is likely), I will rework this series on top of it. I left it >> on v3.3-rc7 now to make testing easier. > > I have re-based your series against Len Browns > next branch [1] which has time keeping and other cpuidle patches. > Have also folded the CPU hotplug fix which I posted in the > original coupled idle patch. > As you know, we have been playing around this series for OMAP for last few weeks. This version series seems to work as intended and found it pretty stable in my testing. Apart from the cpu hotplug fix and the trace event comment, series looks fine to me. FWIW, Reviewed-by: Santosh Shilimkar Tested-by: Santosh Shilimkar An updated version of this series along with OMAP cpuidle driver updates against 3.4-rc2 is available here [1] in case some body is interested looking at it. Regards Santosh [1] git://gitorious.org/omap-sw-develoment/linux-omap-dev.git for_3.5/coupled_cpuidle-rebase