From: Ryan O'Hara <rohara@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] fence_scsi_test: increment error count when reservation fails
Date: Mon, 09 Apr 2012 09:34:50 -0500 [thread overview]
Message-ID: <4F82F38A.2080200@redhat.com> (raw)
If the do_action_on subroutine fails to create a reservation, the
error count should be incremented not set to zero.
Resolves: rhbz#809481
Signed-off-by: Ryan O'Hara <rohara@redhat.com>
---
fence/agents/scsi/fence_scsi_test.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fence/agents/scsi/fence_scsi_test.pl
b/fence/agents/scsi/fence_scsi_test.pl
index 5c2302c..c012a12 100755
--- a/fence/agents/scsi/fence_scsi_test.pl
+++ b/fence/agents/scsi/fence_scsi_test.pl
@@ -44,7 +44,7 @@ sub do_action_on (\@$$)
if (scalar (get_keys_reserve ($dev)) == 0) {
if (do_reserve ($dev, $node_key) != 0) {
- $err = 0;
+ $err++;
}
}
-- 1.7.1
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Attached Message Part
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20120409/aebee3f2/attachment.ksh>
next reply other threads:[~2012-04-09 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 14:34 Ryan O'Hara [this message]
2012-04-09 17:11 ` [Cluster-devel] [PATCH] fence_scsi_test: increment error count when reservation fails Lon Hohberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F82F38A.2080200@redhat.com \
--to=rohara@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.