From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v2 2/2] cgroup: get rid of populate for memcg Date: Mon, 9 Apr 2012 14:51:10 -0300 Message-ID: <4F83218E.7060502@parallels.com> References: <1333728250-14248-1-git-send-email-glommer@parallels.com> <1333728250-14248-3-git-send-email-glommer@parallels.com> <20120409174042.GA7522@google.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120409174042.GA7522-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Tejun Heo Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, Li Zefan , Johannes Weiner , Michal Hocko , Balbir Singh On 04/09/2012 02:40 PM, Tejun Heo wrote: > which BTW seems incorrect even on its > own - unmounting and mounting again would probably make the same > notifier registered multiple times corrupting notification chain, and > ref inc on the parent. For the maintainers: Should I fix those in a new submission, or do you intend to do it yourselves? the refcnt dropping should probably be done in my patch, it is a new leak (sorry). The hotplug notifier, as tejun pointed, was already there. It seems simple enough to fix, so if you guys want, I can bundle it in a new submission. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v2 2/2] cgroup: get rid of populate for memcg Date: Mon, 9 Apr 2012 14:51:10 -0300 Message-ID: <4F83218E.7060502@parallels.com> References: <1333728250-14248-1-git-send-email-glommer@parallels.com> <1333728250-14248-3-git-send-email-glommer@parallels.com> <20120409174042.GA7522@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , , Li Zefan , Johannes Weiner , Michal Hocko , Balbir Singh To: Tejun Heo Return-path: In-Reply-To: <20120409174042.GA7522-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 04/09/2012 02:40 PM, Tejun Heo wrote: > which BTW seems incorrect even on its > own - unmounting and mounting again would probably make the same > notifier registered multiple times corrupting notification chain, and > ref inc on the parent. For the maintainers: Should I fix those in a new submission, or do you intend to do it yourselves? the refcnt dropping should probably be done in my patch, it is a new leak (sorry). The hotplug notifier, as tejun pointed, was already there. It seems simple enough to fix, so if you guys want, I can bundle it in a new submission.