From: Andi Kleen <ak@linux.intel.com>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][REGRESSION] panic: fix stack dump print on direct call to panic()
Date: Mon, 09 Apr 2012 11:34:48 -0700 [thread overview]
Message-ID: <4F832BC8.4090907@linux.intel.com> (raw)
In-Reply-To: <1333992030-21181-1-git-send-email-jason.wessel@windriver.com>
> The proper way to resolve the problem that original commit tried to
> solve is to avoid printing a stack dump from panic() when the either
> of the following conditions is true:
>
> 1) TAINT_DIE has been set (this is done by oops_end())
> This indicates and oops has already been printed.
> 2) oops_in_progress> 1
> This guards against the rare case where panic() is invoked
> a second time, or in between oops_begin() and oops_end()
Oops. I guess can just revert it for now. Thanks for catching, Jason.
The proper solution is probably some variant of
http://git.kernel.org/?p=linux/kernel/git/ak/linux-mce-2.6.git;a=shortlog;h=refs/heads/mce/xpanic
Let the caller pass in the proper action instead of all these hacks.
-Andi
next prev parent reply other threads:[~2012-04-09 18:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 17:20 [PATCH][REGRESSION] panic: fix stack dump print on direct call to panic() Jason Wessel
2012-04-09 18:34 ` Andi Kleen [this message]
2012-04-09 19:08 ` Jason Wessel
2012-04-09 19:36 ` Andi Kleen
2012-04-10 19:19 ` Andrew Morton
2012-04-10 23:29 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F832BC8.4090907@linux.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.