All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Dave Airlie <airlied@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux Wireless List <linux-wireless@vger.kernel.org>
Subject: Re: oops on rmmod of rtl8192ce
Date: Mon, 09 Apr 2012 14:16:43 -0500	[thread overview]
Message-ID: <4F83359B.90103@lwfinger.net> (raw)
In-Reply-To: <CAPM=9tzqwZpWP9Ea-UVWYFcoVY-fa+jCf5FOShiMTrY4roN-og@mail.gmail.com>

On 04/09/2012 10:02 AM, Dave Airlie wrote:
> ping any ideas on this oops on unload?

Sorry about the delay.

The oops looks like interrupts are not being disabled soon enough. Does the 
following patch help?


Index: wireless-testing-new/drivers/net/wireless/rtlwifi/pci.c
===================================================================
--- wireless-testing-new.orig/drivers/net/wireless/rtlwifi/pci.c
+++ wireless-testing-new/drivers/net/wireless/rtlwifi/pci.c
@@ -1943,6 +1943,7 @@ void rtl_pci_disconnect(struct pci_dev *
  		rtl_deinit_deferred_work(hw);
  		rtlpriv->intf_ops->adapter_stop(hw);
  	}
+	rtlpriv->cfg->ops->disable_interrupt(hw);

  	/*deinit rfkill */
  	rtl_deinit_rfkill(hw);

Larry

  reply	other threads:[~2012-04-09 19:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19  8:25 oops on rmmod of rtl8192ce Dave Airlie
2012-04-09 15:02 ` Dave Airlie
2012-04-09 19:16   ` Larry Finger [this message]
2012-04-18 14:16     ` Dave Airlie
2012-04-18 15:08       ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F83359B.90103@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=airlied@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.