diff for duplicates of <4F840442.5060706@openwrt.org> diff --git a/a/1.txt b/N1/1.txt index 3ccbf1f..a9827dd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,7 +7,7 @@ On 2012-04-10 11:04 AM, Dan Carpenter wrote: > "->ofdmWeakSigDetectOff" and "->ofdm_weak_signal_on" variables are both > boolean. > -> Or perhaps based we could change the != to an == and remove the negate? +> Or perhaps based we could change the != to an = and remove the negate? > > But normally when I see this formation it is a precedence bug so that's > the patch I've sent. @@ -22,10 +22,8 @@ On 2012-04-10 11:04 AM, Dan Carpenter wrote: > entry_ofdm->fir_step_level); > > if ((aniState->noiseFloor >= aniState->rssiThrHigh) && -> - (!aniState->ofdmWeakSigDetectOff != -> + (aniState->ofdmWeakSigDetectOff != -Looking at other Atheros code, I think this patch is wrong, it should -be: aniState->ofdmWeakSigDetectOff == entry_ofdm->ofdm_weak_signal_on +> - (!aniState->ofdmWeakSigDetectOff !> + (aniState->ofdmWeakSigDetectOff !Looking at other Atheros code, I think this patch is wrong, it should +be: aniState->ofdmWeakSigDetectOff = entry_ofdm->ofdm_weak_signal_on While a bit confusing, the behavior of the original code was correct, aniState->ofdmWeakSigDetectOff is used as a boolean. diff --git a/a/content_digest b/N1/content_digest index 359b896..51c9496 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,17 @@ "ref\020120410090445.GB26832@elgon.mountain\0" "From\0Felix Fietkau <nbd@openwrt.org>\0" - "Subject\0[ath9k-devel] [RFC] ath9k_hw: precedence bug in ath9k_hw_set_ofdm_nil()\0" - "Date\0Tue, 10 Apr 2012 11:58:26 +0200\0" - "To\0ath9k-devel@lists.ath9k.org\0" + "Subject\0Re: [ath9k-devel] [RFC] ath9k_hw: precedence bug in ath9k_hw_set_ofdm_nil()\0" + "Date\0Tue, 10 Apr 2012 09:58:26 +0000\0" + "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "Cc\0Luis R. Rodriguez <mcgrof@qca.qualcomm.com>" + Rajkumar Manoharan <rmanohar@qca.qualcomm.com> + Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com> + ath9k-devel@venema.h4ckr.net + kernel-janitors@vger.kernel.org + Jouni Malinen <jouni@qca.qualcomm.com> + linux-wireless@vger.kernel.org + John W. Linville <linville@tuxdriver.com> + " Senthil Balasubramanian <senthilb@qca.qualcomm.com>\0" "\00:1\0" "b\0" "On 2012-04-10 11:04 AM, Dan Carpenter wrote:\n" @@ -14,7 +23,7 @@ "> \"->ofdmWeakSigDetectOff\" and \"->ofdm_weak_signal_on\" variables are both\n" "> boolean.\n" "> \n" - "> Or perhaps based we could change the != to an == and remove the negate?\n" + "> Or perhaps based we could change the != to an = and remove the negate?\n" "> \n" "> But normally when I see this formation it is a precedence bug so that's\n" "> the patch I've sent.\n" @@ -29,10 +38,8 @@ "> \t\t\t\t entry_ofdm->fir_step_level);\n" "> \n" "> \tif ((aniState->noiseFloor >= aniState->rssiThrHigh) &&\n" - "> -\t (!aniState->ofdmWeakSigDetectOff !=\n" - "> +\t (aniState->ofdmWeakSigDetectOff !=\n" - "Looking at other Atheros code, I think this patch is wrong, it should\n" - "be: aniState->ofdmWeakSigDetectOff == entry_ofdm->ofdm_weak_signal_on\n" + "> -\t (!aniState->ofdmWeakSigDetectOff !> +\t (aniState->ofdmWeakSigDetectOff !Looking at other Atheros code, I think this patch is wrong, it should\n" + "be: aniState->ofdmWeakSigDetectOff = entry_ofdm->ofdm_weak_signal_on\n" "\n" "While a bit confusing, the behavior of the original code was correct,\n" "aniState->ofdmWeakSigDetectOff is used as a boolean.\n" @@ -42,4 +49,4 @@ "\n" - Felix -16dbd08be5ea205223485f543da03794c883694265bbdf34778766a05bfa53b7 +559fffffd65736ceb7c8191e8db82ae885755c5319afd83c9df2ca871c81526f
diff --git a/a/content_digest b/N2/content_digest index 359b896..7d64caa 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,8 +1,17 @@ "ref\020120410090445.GB26832@elgon.mountain\0" "From\0Felix Fietkau <nbd@openwrt.org>\0" - "Subject\0[ath9k-devel] [RFC] ath9k_hw: precedence bug in ath9k_hw_set_ofdm_nil()\0" + "Subject\0Re: [ath9k-devel] [RFC] ath9k_hw: precedence bug in ath9k_hw_set_ofdm_nil()\0" "Date\0Tue, 10 Apr 2012 11:58:26 +0200\0" - "To\0ath9k-devel@lists.ath9k.org\0" + "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "Cc\0Luis R. Rodriguez <mcgrof@qca.qualcomm.com>" + Rajkumar Manoharan <rmanohar@qca.qualcomm.com> + Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com> + ath9k-devel@venema.h4ckr.net + kernel-janitors@vger.kernel.org + Jouni Malinen <jouni@qca.qualcomm.com> + linux-wireless@vger.kernel.org + John W. Linville <linville@tuxdriver.com> + " Senthil Balasubramanian <senthilb@qca.qualcomm.com>\0" "\00:1\0" "b\0" "On 2012-04-10 11:04 AM, Dan Carpenter wrote:\n" @@ -42,4 +51,4 @@ "\n" - Felix -16dbd08be5ea205223485f543da03794c883694265bbdf34778766a05bfa53b7 +82950916c2dd1110bc7a59adefc9d70d2e494c5d52b4527aa9410919a1946242
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.