From: Andreas WESTIN <andreas.westin@stericsson.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"kim.phillips@freescale.com" <kim.phillips@freescale.com>
Subject: Re: [PATCH 2/3 v4] crypto: ux500: Add driver for HASH hardware
Date: Tue, 10 Apr 2012 12:25:16 +0200 [thread overview]
Message-ID: <4F840A8C.7030103@stericsson.com> (raw)
In-Reply-To: <20120409070919.GA30624@gondor.apana.org.au>
On 2012-04-09 09:09, Herbert Xu wrote:
> On Fri, Mar 30, 2012 at 11:02:47AM +0200, Andreas Westin wrote:
>>
>> +/**
>> + * hash_hw_update - Updates current HASH computation hashing another part of
>> + * the message.
>> + * @req: Byte array containing the message to be hashed (caller
>> + * allocated).
>> + *
>> + * Reentrancy: Non Re-entrant
>> + */
>
> As the crypto API is reentrant this comment suggests that this
> driver cannot be accepted as is.
This is a legacy comment, it does not apply anymore. I will remove it
and create a new patch.
Cheers
Andreas
next prev parent reply other threads:[~2012-04-10 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 9:02 [PATCH 0/3 v4] crypto: ux500 crypto and hash driver Andreas Westin
2012-03-30 9:02 ` [PATCH 1/3 v4] crypto: ux500: Add driver for CRYP hardware Andreas Westin
2012-03-30 9:02 ` [PATCH 2/3 v4] crypto: ux500: Add driver for HASH hardware Andreas Westin
2012-04-09 7:09 ` Herbert Xu
2012-04-10 10:25 ` Andreas WESTIN [this message]
2012-03-30 9:02 ` [PATCH 3/3 v4] mach-ux500: Crypto: core support for CRYP/HASH module Andreas Westin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F840A8C.7030103@stericsson.com \
--to=andreas.westin@stericsson.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kim.phillips@freescale.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.