All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: mingo@redhat.com, acme@ghostprotocols.net,
	a.p.zijlstra@chello.nl, paulus@samba.org, fweisbec@gmail.com,
	eranian@google.com, linux-kernel@vger.kernel.org
Subject: Re: [BUG PATCH] perf: kvm - finding struct machine fails for PERF_RECORD_MMAP
Date: Tue, 10 Apr 2012 09:14:51 -0600	[thread overview]
Message-ID: <4F844E6B.2070005@gmail.com> (raw)
In-Reply-To: <87iph8xnim.fsf@abhimanyu.in.ibm.com>

On 4/9/12 9:40 PM, Nikunj A Dadhania wrote:
> I can think of two places where it can happen:
>
> 1) perf_event__synthesize_kernel_mmap
>
>          [...]
>   	mmap_name = machine__mmap_name(machine, name_buff, sizeof(name_buff));
> 	if (machine__is_host(machine)) {
>             ...
> 	} else {
> 		event->header.misc = PERF_RECORD_MISC_GUEST_KERNEL;
> 		if (machine__is_default_guest(machine))
> 			filename = (char *) symbol_conf.default_guest_kallsyms;
> 		else {
> 			sprintf(path, "%s/proc/kallsyms", machine->root_dir);
> 			filename = path;
> 		}
> 	}
>          [...]
> 	event->mmap.header.type = PERF_RECORD_MMAP;
>          [...]
>          event->mmap.pid   = machine->pid;
>
> 2) perf_event__synthesize_modules
>
>          [...]
> 	if (machine__is_host(machine))
> 		event->header.misc = PERF_RECORD_MISC_KERNEL;
> 	else
> 		event->header.misc = PERF_RECORD_MISC_GUEST_KERNEL;
>          [...]
> 	event->mmap.header.type = PERF_RECORD_MMAP;
>          [...]
>          event->mmap.pid   = machine->pid;
>
> BTW, i am testing this on latest -tip(498c911).
>
> In my case, I am able to recreate this everytime. And have verified that
> the event->header.type that I hit here is of type PERF_RECORD_MMAP.

I was thinking runtime, not initialization. Adding -o direct_io to the 
sshfs mount did the trick. Reading guest /proc files exposes the segfault.

David

  reply	other threads:[~2012-04-10 15:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09  8:22 [BUG PATCH] perf: kvm - finding struct machine fails for PERF_RECORD_MMAP Nikunj A. Dadhania
2012-04-09 20:17 ` David Ahern
2012-04-09 22:59 ` David Ahern
2012-04-10  3:40   ` Nikunj A Dadhania
2012-04-10 15:14     ` David Ahern [this message]
2012-04-10 15:16 ` David Ahern
2012-04-11 14:47   ` Arnaldo Carvalho de Melo
2012-04-13 18:13 ` [tip:perf/urgent] perf kvm: Finding " tip-bot for Nikunj A. Dadhania

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F844E6B.2070005@gmail.com \
    --to=dsahern@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nikunj@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.