From: Stephen Warren <swarren@wwwdotorg.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: gregkh@linuxfoundation.org,
Sudhakar Mamillapalli <sudhakar@fb.com>,
linux-kernel@vger.kernel.org, ArndBergmannarnd@arndb.de,
Grant Likely <grant.likely@secretlab.ca>,
linux-serial@vger.kernel.org, Colin Cross <ccross@android.com>,
Olof Johansson <olof@lixom.net>,
Nhan H Mai <nhan.h.mai@intel.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH v3 1/3] tegra, serial8250: add ->handle_break() uart_port op
Date: Tue, 10 Apr 2012 12:17:00 -0600 [thread overview]
Message-ID: <4F84791C.7090307@wwwdotorg.org> (raw)
In-Reply-To: <CABE8wwsDM=4Lp5Fa79V29tG2RypfA-MxN7zfhtze7sOLCVdL7A@mail.gmail.com>
On 04/10/2012 11:36 AM, Dan Williams wrote:
> On Tue, Apr 10, 2012 at 8:53 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 04/09/2012 01:48 PM, Dan Williams wrote:
>>> The "KT" serial port has another use case for a "received break" quirk,
>>> so before adding another special case to the 8250 core take this
>>> opportunity to push such quirks out of the core and into a uart_port op.
...
>>> diff --git a/include/linux/of_serial.h b/include/linux/of_serial.h
>> ...
>>> + * FIXME remove this file when tegra finishes conversion to open firmware,
>>
>> remove this *prototype* not *file*?
>
> The entire file should go away since it is only there to export
> tegra_serial_handle_break to the deprecated board files. Once this is
> open firmware only tegra_serial_handle_break can be marked static,
> right?
Ah yes, right.
next prev parent reply other threads:[~2012-04-10 18:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 19:48 [PATCH v3 0/3] rework quirks for the "kt" serial port Dan Williams
2012-04-09 19:48 ` [PATCH v3 1/3] tegra, serial8250: add ->handle_break() uart_port op Dan Williams
2012-04-09 19:41 ` Williams, Dan J
2012-04-09 19:41 ` Williams, Dan J
2012-04-09 19:48 ` Stephen Warren
2012-04-09 20:48 ` Williams, Dan J
2012-04-09 20:48 ` Williams, Dan J
2012-04-10 10:51 ` Arnd Bergmann
2012-04-10 15:53 ` Stephen Warren
2012-04-10 17:36 ` Dan Williams
2012-04-10 18:17 ` Stephen Warren [this message]
2012-04-09 19:49 ` [PATCH v3 2/3] serial/8250_pci: Clear FIFOs for Intel ME Serial Over Lan device on BI Dan Williams
2012-04-09 19:49 ` [PATCH v3 3/3] serial/8250_pci: fix suspend/resume vs init/exit quirks Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F84791C.7090307@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=ArndBergmannarnd@arndb.de \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ccross@android.com \
--cc=dan.j.williams@intel.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nhan.h.mai@intel.com \
--cc=olof@lixom.net \
--cc=sudhakar@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.