Re: [PATCH 2/2] sato: Throw warning when building ISO image without unionfs enabled

[Yang Shi <yang.shi@windriver.com>]

On 4/10/2012 12:06 PM, Saul Wold wrote:
> On 04/09/2012 03:15 PM, Yang Shi wrote:
>> [YOCTO #1487]
>>
>> For the liveCD image, interactive bootup is needed, but psplash 
>> prevents from
>> booting interactively. In such case ISO image is not usable, so throw 
>> warning
>> info when building ISO image without unionfs enabled in kernel.
>>
>> Signed-off-by: Yang Shi<yang.shi@windriver.com>
>> ---
>>   meta/recipes-sato/images/core-image-sato.bb |   14 ++++++++++++++
>>   1 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/recipes-sato/images/core-image-sato.bb 
>> b/meta/recipes-sato/images/core-image-sato.bb
>> index 11c3318..871b227 100644
>> --- a/meta/recipes-sato/images/core-image-sato.bb
>> +++ b/meta/recipes-sato/images/core-image-sato.bb
>> @@ -9,3 +9,17 @@ IMAGE_FEATURES += "apps-console-core 
>> ${SATO_IMAGE_FEATURES}"
>>   LICENSE = "MIT"
>>
>>   inherit core-image
>> +
>> +LIVE = "${@base_contains('IMAGE_FSTYPES', 'live', 'yes', 'no', d)}"
>> +
>> +do_check_unionfs() {
>> +        if [ "${NOISO}" = "1" ]; then
>> +                return
>> +        fi
>> +
>> +        if [ "${LIVE}" = "yes" ]&&  ! grep -q "CONFIG_UNION_FS=y" 
>> ${STAGING_KERNEL_DIR}/.config; then
> I think you are missing a "]" at the end of this "if [" test.

It is 'if [ "${LIVE}" = "yes" ]'.

>> +                bbwarn "Building LIVE CD without UNION FS enabled in 
>> kernel"
>> +        fi
>> +}
>> +
>> +addtask check_unionfs before do_build after do_bootimg
>
> This change is causing a new failure:

Yes, I mentioned this in my mail, the workaround is to add IMAGE_FSTYPE 
+= "live" in conf/local.conf

Bruce pointed out this is a known problem in poky.

Thanks,
Yang

>
> Traceback (most recent call last):
>   File 
> "/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-arm/build/bitbake/lib/bb/server/process.py", 
> line 122, in ProcessServer.idle_commands(delay=0.1):
>                  try:
> >                retval = function(self, data, False)
>                      if retval is False:
>   File 
> "/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-arm/build/bitbake/lib/bb/cooker.py", 
> line 1134, in buildTargetsIdle(server=<ProcessServer(ProcessServer-1, 
> started)>, rq=<bb.runqueue.RunQueue instance at 0xb6891b8>, abort=False):
>                  try:
> >                retval = rq.execute_runqueue()
>                  except runqueue.TaskFailure as exc:
>   File 
> "/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-arm/build/bitbake/lib/bb/runqueue.py", 
> line 948, in RunQueue.execute_runqueue():
>                  self.rqexe = RunQueueExecuteDummy(self)
> >            if self.rqdata.prepare() == 0:
>                      self.state = runQueueComplete
>   File 
> "/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-arm/build/bitbake/lib/bb/runqueue.py", 
> line 719, in RunQueueData.prepare():
>
> procdep.append(self.taskData.fn_index[self.runq_fnid[dep]] + "." + 
> self.runq_task[dep])
> >                    self.runq_hash[task] = 
> bb.parse.siggen.get_taskhash(self.taskData.fn_index[self.runq_fnid[task]], 
> self.runq_task[task], procdep, self.dataCache)
>
>   File 
> "/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-arm/build/bitbake/lib/bb/siggen.py", 
> line 153, in 
> SignatureGeneratorOEBasicHash.get_taskhash(fn='/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-arm/build/meta/recipes-sato/images/core-image-sato.bb', 
> task='do_bootimg', deps=[], dataCache=<bb.cache.CacheData object at 
> 0x2ede190>):
>              k = fn + "." + task
> >        data = dataCache.basetaskhash[k]
>              self.runtaskdeps[k] = []
> KeyError: 
> '/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-arm/build/meta/recipes-sato/images/core-image-sato.bb.do_bootimg'
>
>