From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Marek Chmielewski <marek.chmielewski@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: Add usb device id for tm6000-cards.c
Date: Tue, 10 Apr 2012 19:58:06 -0300 [thread overview]
Message-ID: <4F84BAFE.60301@redhat.com> (raw)
In-Reply-To: <CAG9CFj=UWR4pSW=aYLTQiC5W+LTQHxzdAVnZ-is1vXisMWkBoQ@mail.gmail.com>
Em 22-03-2012 16:37, Marek Chmielewski escreveu:
> -- Pozdrawiam Marek Chmielewski
>
>
> patch_for_tm6000-cards.patch
>
>
> --- tm6000-cards.c.bakup 2012-03-10 14:34:07.471348336 +0100
> +++ tm6000-cards.c 2012-03-10 15:18:09.856380721 +0100
Please, use it ad diff -p1 format (e. g. a/drivers/media/video/tm6000/tm6000-cards.c).
A tool like quilt or git would do it for you.
> @@ -615,6 +615,7 @@
> struct usb_device_id tm6000_id_table[] = {
> { USB_DEVICE(0x6000, 0x0001), .driver_info = TM5600_BOARD_GENERIC },
> { USB_DEVICE(0x6000, 0x0002), .driver_info = TM6010_BOARD_GENERIC },
> + { USB_DEVICE(0x0572, 0x262a), .driver_info = TM5600_BOARD_GENERIC },
Hmm... different USB vendor??? Are you sure this is a generic board? It seems unlikely that
Trident would be using a different Vendor ID there.
If this is not a "Generic" ID (e.g. a Trident SDK ID), then you should, instead, create an
entry for your board.
> { USB_DEVICE(0x06e1, 0xf332), .driver_info = TM6000_BOARD_ADSTECH_DUAL_TV },
> { USB_DEVICE(0x14aa, 0x0620), .driver_info = TM6000_BOARD_FREECOM_AND_SIMILAR },
> { USB_DEVICE(0x06e1, 0xb339), .driver_info = TM6000_BOARD_ADSTECH_MINI_DUAL_TV },
>
Regards,
Mauro
prev parent reply other threads:[~2012-04-10 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 19:37 Add usb device id for tm6000-cards.c Marek Chmielewski
2012-03-22 20:20 ` Sylwester Nawrocki
2012-04-10 22:58 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F84BAFE.60301@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=marek.chmielewski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.