Re: hfp voicecall fails to register in ofono with iPhone voicemail

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1994 bytes --]

Hi Mike,

On 04/10/2012 05:53 PM, Mike wrote:
> On Fri, Apr 6, 2012 at 10:53 AM, Mike <puffy.taco@gmail.com> wrote:
>> Hi Denis,
>>
>> On Fri, Apr 6, 2012 at 9:36 AM, Denis Kenzior <denkenz@gmail.com> wrote:
>>> Hi Mike,
>>>
>>> On 04/05/2012 11:28 PM, Mike wrote:
>>>> I'm experiencing an issue where the +CLCC response provided by an
>>>> iPhone is ignored in the case of a user utilizing visual voicemail.
>>>> The problem here is that the AT+CLCC is being sent in response to a
>>>> +CIEV indicating call setup, but by the time the +CLCC response comes
>>>> back, the call status is active.  This is a problem because the
>>>> callback, sync_dialing_cb, is specifically looking for calls in the
>>>> dialing state.  It looks like at least some bits from clcc_poll_cb
>>>> should be copied into sync_dialing_cb (or a helper function) because I
>>>> would think any time we get a +CLCC we would want to completely update
>>>> our call list (and therefore fix the issue I'm encountering).  I'm
>>>> still digging into this, but as I'm not familiar with all the quirks
>>>> of devices out there, I'm throwing this out there in case anyone has
>>>> some ideas on this.
>>>
>>> Are you dialing from the HF or the AG side?  And yes, the logic in
>>> find_dialing() might indeed need to be changed to also find single
>>> active calls.
>>
>> Dialing is on the AG side.
> 
> It looks like simply adding "	clcc_poll_cb(ok, result, user_data);" to
> the end of sync_dialing_cb fixes this problem.  We end up parsing the
> result twice, but it was an easy test.  Does that seem like the right
> path?
> 

Yes, sync_dialing_cb was likely a holdover from when we didn't think
we'd need the expensive clcc polling logic.  Hence a somewhat optimized
version that doesn't seem to work in case a call skips the alerting stage.

Removing sync_dialing_cb and using clcc_poll_cb seems reasonable to me.
 Care to test this theory and submit a patch?

Regards,
-Denis