From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: "ltp-list@lists.sourceforge.net" <ltp-list@lists.sourceforge.net>,
Mike Frysinger <vapier@gentoo.org>
Subject: Re: [LTP] [PATCH 1/2] Clean up inotify(7) wrappers
Date: Wed, 11 Apr 2012 17:25:14 +0800 [thread overview]
Message-ID: <4F854DFA.20704@cn.fujitsu.com> (raw)
In-Reply-To: <45B655E5-9D04-457E-ADD6-4B79761A3B68@gmail.com>
On 04/11/2012 05:21 PM, Garrett Cooper wrote:
> On Apr 10, 2012, at 7:52 PM, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
>
>> On 04/05/2012 09:52 AM, Mike Frysinger wrote:
>>
>>> On Wednesday 04 April 2012 20:38:31 Garrett Cooper wrote:
>>>> +/*
>>>> + * ``junk`` is needed to make the macro function like a void argument
>>>> + * function.
>>>> + */
>>>> +#define myinotify_init(junk) syscall(__NR_inotify_init)
>>>
>>> you lost me. how does this make it work like a (void) func ? i think this
>>> should drop the "junk" and just do:
>>> #define myinotify_init() ...
>>
>>
>> Cooper,
>>
>> Any update on what Mike said?
>
> Simply put, his method is cleaner/better. I need to produce a new patch with his suggested change.
That's great!
Thanks,
Wanlong Gao
>
> Thanks!
> -Garrett
>
------------------------------------------------------------------------------
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2012-04-11 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 0:38 [LTP] [PATCH 1/2] Clean up inotify(7) wrappers Garrett Cooper
2012-04-05 1:36 ` Wanlong Gao
2012-04-05 1:52 ` Mike Frysinger
2012-04-11 2:52 ` Wanlong Gao
2012-04-11 9:21 ` Garrett Cooper
2012-04-11 9:25 ` Wanlong Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F854DFA.20704@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.