Re: [PATCH] mmc: omap_hsmmc: Get rid of of_have_populated_dt() usage

[Rajendra Nayak <rnayak@ti.com>]

On Wednesday 11 April 2012 03:56 PM, Felipe Balbi wrote:
> On Wed, Apr 11, 2012 at 03:54:28PM +0530, Rajendra Nayak wrote:
>> On Wednesday 11 April 2012 03:39 PM, Felipe Balbi wrote:
>>> On Wed, Apr 11, 2012 at 03:33:13PM +0530, Rajendra Nayak wrote:
>>>> @@ -1564,7 +1564,7 @@ static void omap_hsmmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>>>>   			 * can't be allowed when booting with device
>>>>   			 * tree.
>>>>   			 */
>>>> -			(!of_have_populated_dt())) {
>>>> +			!host->dev->of_node) {
>>>
>>> won't compile
>>>
>> why? compiles fine for me.
>
> aren't you missing the opening parenthesis ? Or is there a something not
> shown in the context ?
>
Its the missing context thats confusing :-)

This is how the code looks in the file after the patch.

                if ((OMAP_HSMMC_READ(host->base, HCTL) & SDVSDET) &&
                         (ios->vdd == DUAL_VOLT_OCR_BIT) &&
                         /*
                          * With pbias cell programming missing, this
                          * can't be allowed when booting with device
                          * tree.
                          */
                         !host->dev->of_node) {