From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SHut1-0008QG-Rm for kexec@lists.infradead.org; Wed, 11 Apr 2012 10:34:52 +0000 Message-ID: <4F855E3C.9010003@cn.fujitsu.com> Date: Wed, 11 Apr 2012 18:34:36 +0800 From: zhangyanfei MIME-Version: 1.0 Subject: Re: [PATCH 2/4] KVM: VMX: Add functions to fill VMCSINFO References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E365.10201@cn.fujitsu.com> <4F85454E.6020201@redhat.com> In-Reply-To: <4F85454E.6020201@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Avi Kivity Cc: dzickus@redhat.com, luto@mit.edu, gregkh@suse.de, kvm@vger.kernel.org, joerg.roedel@amd.com, mtosatti@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, ebiederm@xmission.com 5LqOIDIwMTLlubQwNOaciDEx5pelIDE2OjQ4LCBBdmkgS2l2aXR5IOWGmemBkzoKPiBPbiAwNC8x MS8yMDEyIDA0OjUwIEFNLCB6aGFuZ3lhbmZlaSB3cm90ZToKPj4gVGhpcyBwYXRjaCBpcyB0byBp bXBsZW1lbnQgdGhlIGZlYXR1cmUgdGhhdCBhdCBpbml0aWFsaXphdGlvbiBvZgo+PiBrdm1faW50 ZWwgbW9kdWxlLCBmaWxscyBWTUNTSU5GTyB3aXRoIGEgVk1DUyByZXZpc2lvbiBpZGVudGlmaWVy LAo+PiBhbmQgZW5jb2RlZCBvZmZzZXRzIG9mIFZNQ1MgZmllbGRzLiBUaGUgcmVhc29uIHdoeSB3 ZSBwdXQgdGhlCj4+IFZNQ1NJTkZPIHByb2Nlc3NpbmcgYXQgdGhlIGluaXRpYWxpemF0aW9uIG9m IGt2bV9pbnRlbCBtb2R1bGUKPj4gaXMgdGhhdCBpdCdzIGRhbmdlcm91cyB0byByb2IgVk1YIHJl c291cmNlcyB3aGlsZSBrdm0gbW9kdWxlIGlzCj4+IGxvYWRlZC4KPiAKPiBNYXliZSBpdCBzaG91 bGQgYmUgZG9uZSBieSBhIHNlcGFyYXRlIG1vZHVsZS4KPiAKCklmIHdlIHB1dCB2bWNzaW5mbyBw cm9jZXNzaW5nIGF0IHRoZSBpbml0aWFsaXphdGlvbiBvZiBrdm1faW50ZWwgbW9kdWxlLAphcyBz b29uIGFzIHRoZSBrdm1faW50ZWwgbW9kdWxlIGlzIGxvYWRlZCwgVk1DU0lORk8gaXMgZmlsbGVk LiBBbmQgaXQgaXMKYmVjYXVzZSB2bWNzaW5mbyBwcm9jZXNzaW5nIGlzIGF0IHRoZSBpbml0aWFs aXphdGlvbiBvZiBrdm1faW50ZWwgbW9kdWxlLApubyBrdm0gZ3Vlc3RzIGFyZSBydW5uaW5nLCBz byBpdCB3aWxsIG5vdCByb2IgYW55IFZNWCByZXNvdXJjZXMuCgpJZiBpdCBpcyBkb25lIGJ5IGEg c2VwYXJhdGUgbW9kdWxlLCBJIGFtIGFmcmFpZCB0aGlzIG1vZHVsZSBtYXkgbm90IGJlCmxvYWRl ZCB3aGVuIHRoZSBrZXJuZWwgbmVlZHMgVk1DU0lORk8uCgo+PiArCj4+ICsJa3ZtX2NwdV92bXhv bihfX3BhKHBlcl9jcHUodm14YXJlYSwgcmF3X3NtcF9wcm9jZXNzb3JfaWQoKSkpKTsKPj4gKwl2 bWNzX2xvYWQodm1jcyk7Cj4gCj4gU2hvdWxkIGRvIHRoaXMgYWZ0ZXIgd3JpdGluZyBpbnRvIHRo ZSB2bWNzIGRpcmVjdGx5ICh2bWNzX2xvYWQoKSBtYXkKPiBjYWNoZSBzb21lIGluZm9ybWF0aW9u IGZvciB2bWNzX3JlYWQoKSkuCj4KCkhtbSwgdGhhbmtzIGZvciBwb2ludGluZyB0aGlzLgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxp bmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhangyanfei Subject: Re: [PATCH 2/4] KVM: VMX: Add functions to fill VMCSINFO Date: Wed, 11 Apr 2012 18:34:36 +0800 Message-ID: <4F855E3C.9010003@cn.fujitsu.com> References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E365.10201@cn.fujitsu.com> <4F85454E.6020201@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: dzickus-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, luto-3s7WtUTddSA@public.gmane.org, gregkh-l3A5Bk7waGM@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, joerg.roedel-5C7GfCeVMHo@public.gmane.org, mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org, ludwig.nussel-l3A5Bk7waGM@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <4F85454E.6020201-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org 5LqOIDIwMTLlubQwNOaciDEx5pelIDE2OjQ4LCBBdmkgS2l2aXR5IOWGmemBkzoKPiBPbiAwNC8x MS8yMDEyIDA0OjUwIEFNLCB6aGFuZ3lhbmZlaSB3cm90ZToKPj4gVGhpcyBwYXRjaCBpcyB0byBp bXBsZW1lbnQgdGhlIGZlYXR1cmUgdGhhdCBhdCBpbml0aWFsaXphdGlvbiBvZgo+PiBrdm1faW50 ZWwgbW9kdWxlLCBmaWxscyBWTUNTSU5GTyB3aXRoIGEgVk1DUyByZXZpc2lvbiBpZGVudGlmaWVy LAo+PiBhbmQgZW5jb2RlZCBvZmZzZXRzIG9mIFZNQ1MgZmllbGRzLiBUaGUgcmVhc29uIHdoeSB3 ZSBwdXQgdGhlCj4+IFZNQ1NJTkZPIHByb2Nlc3NpbmcgYXQgdGhlIGluaXRpYWxpemF0aW9uIG9m IGt2bV9pbnRlbCBtb2R1bGUKPj4gaXMgdGhhdCBpdCdzIGRhbmdlcm91cyB0byByb2IgVk1YIHJl c291cmNlcyB3aGlsZSBrdm0gbW9kdWxlIGlzCj4+IGxvYWRlZC4KPiAKPiBNYXliZSBpdCBzaG91 bGQgYmUgZG9uZSBieSBhIHNlcGFyYXRlIG1vZHVsZS4KPiAKCklmIHdlIHB1dCB2bWNzaW5mbyBw cm9jZXNzaW5nIGF0IHRoZSBpbml0aWFsaXphdGlvbiBvZiBrdm1faW50ZWwgbW9kdWxlLAphcyBz b29uIGFzIHRoZSBrdm1faW50ZWwgbW9kdWxlIGlzIGxvYWRlZCwgVk1DU0lORk8gaXMgZmlsbGVk LiBBbmQgaXQgaXMKYmVjYXVzZSB2bWNzaW5mbyBwcm9jZXNzaW5nIGlzIGF0IHRoZSBpbml0aWFs aXphdGlvbiBvZiBrdm1faW50ZWwgbW9kdWxlLApubyBrdm0gZ3Vlc3RzIGFyZSBydW5uaW5nLCBz byBpdCB3aWxsIG5vdCByb2IgYW55IFZNWCByZXNvdXJjZXMuCgpJZiBpdCBpcyBkb25lIGJ5IGEg c2VwYXJhdGUgbW9kdWxlLCBJIGFtIGFmcmFpZCB0aGlzIG1vZHVsZSBtYXkgbm90IGJlCmxvYWRl ZCB3aGVuIHRoZSBrZXJuZWwgbmVlZHMgVk1DU0lORk8uCgo+PiArCj4+ICsJa3ZtX2NwdV92bXhv bihfX3BhKHBlcl9jcHUodm14YXJlYSwgcmF3X3NtcF9wcm9jZXNzb3JfaWQoKSkpKTsKPj4gKwl2 bWNzX2xvYWQodm1jcyk7Cj4gCj4gU2hvdWxkIGRvIHRoaXMgYWZ0ZXIgd3JpdGluZyBpbnRvIHRo ZSB2bWNzIGRpcmVjdGx5ICh2bWNzX2xvYWQoKSBtYXkKPiBjYWNoZSBzb21lIGluZm9ybWF0aW9u IGZvciB2bWNzX3JlYWQoKSkuCj4KCkhtbSwgdGhhbmtzIGZvciBwb2ludGluZyB0aGlzLgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxp bmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756621Ab2DKKew (ORCPT ); Wed, 11 Apr 2012 06:34:52 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:53164 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750880Ab2DKKeu convert rfc822-to-8bit (ORCPT ); Wed, 11 Apr 2012 06:34:50 -0400 X-IronPort-AV: E=Sophos;i="4.75,405,1330876800"; d="scan'208";a="4730792" Message-ID: <4F855E3C.9010003@cn.fujitsu.com> Date: Wed, 11 Apr 2012 18:34:36 +0800 From: zhangyanfei User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100413 Fedora/3.0.4-2.fc13 Thunderbird/3.0.4 MIME-Version: 1.0 To: Avi Kivity CC: mtosatti@redhat.com, ebiederm@xmission.com, luto@mit.edu, joerg.roedel@amd.com, dzickus@redhat.com, paul.gortmaker@windriver.com, gregkh@suse.de, ludwig.nussel@suse.de, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH 2/4] KVM: VMX: Add functions to fill VMCSINFO References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E365.10201@cn.fujitsu.com> <4F85454E.6020201@redhat.com> In-Reply-To: <4F85454E.6020201@redhat.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/04/11 18:34:12, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/04/11 18:34:14 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2012年04月11日 16:48, Avi Kivity 写道: > On 04/11/2012 04:50 AM, zhangyanfei wrote: >> This patch is to implement the feature that at initialization of >> kvm_intel module, fills VMCSINFO with a VMCS revision identifier, >> and encoded offsets of VMCS fields. The reason why we put the >> VMCSINFO processing at the initialization of kvm_intel module >> is that it's dangerous to rob VMX resources while kvm module is >> loaded. > > Maybe it should be done by a separate module. > If we put vmcsinfo processing at the initialization of kvm_intel module, as soon as the kvm_intel module is loaded, VMCSINFO is filled. And it is because vmcsinfo processing is at the initialization of kvm_intel module, no kvm guests are running, so it will not rob any VMX resources. If it is done by a separate module, I am afraid this module may not be loaded when the kernel needs VMCSINFO. >> + >> + kvm_cpu_vmxon(__pa(per_cpu(vmxarea, raw_smp_processor_id()))); >> + vmcs_load(vmcs); > > Should do this after writing into the vmcs directly (vmcs_load() may > cache some information for vmcs_read()). > Hmm, thanks for pointing this.