From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SHv75-0000bX-Pm for kexec@lists.infradead.org; Wed, 11 Apr 2012 10:49:24 +0000 Message-ID: <4F8561A7.80604@redhat.com> Date: Wed, 11 Apr 2012 13:49:11 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [PATCH 0/4] Export offsets of VMCS fields as note information for kdump References: <4F84E0DF.8040206@cn.fujitsu.com> <20120411102136.GG2428@amd.com> In-Reply-To: <20120411102136.GG2428@amd.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Joerg Roedel Cc: dzickus@redhat.com, luto@mit.edu, gregkh@suse.de, kvm@vger.kernel.org, mtosatti@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, zhangyanfei , ebiederm@xmission.com, ludwig.nussel@suse.de On 04/11/2012 01:21 PM, Joerg Roedel wrote: > Hi, > > On Wed, Apr 11, 2012 at 09:39:43AM +0800, zhangyanfei wrote: > > The problem is that VMCS internal is hidden by Intel in its > > specification. So, we reverse engineering it in the way implemented in > > this patch set. > > Have you made sure this layout is the same on all uarchitectures that > implment VMX? He's determining the layout at runtime. It should even work with kvm's vmx implementation. It's vulnerable to two issues: - fields that are cached in the processor and not flushed to memory (perhaps just make sure to VMXOFF before dumping memory) - fields that are encoded differently in memory than VMREAD/VMWRITE -- error compiling committee.c: too many arguments to function _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/4] Export offsets of VMCS fields as note information for kdump Date: Wed, 11 Apr 2012 13:49:11 +0300 Message-ID: <4F8561A7.80604@redhat.com> References: <4F84E0DF.8040206@cn.fujitsu.com> <20120411102136.GG2428@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dzickus-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, luto-3s7WtUTddSA@public.gmane.org, gregkh-l3A5Bk7waGM@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org, zhangyanfei , ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, ludwig.nussel-l3A5Bk7waGM@public.gmane.org To: Joerg Roedel Return-path: In-Reply-To: <20120411102136.GG2428-5C7GfCeVMHo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org On 04/11/2012 01:21 PM, Joerg Roedel wrote: > Hi, > > On Wed, Apr 11, 2012 at 09:39:43AM +0800, zhangyanfei wrote: > > The problem is that VMCS internal is hidden by Intel in its > > specification. So, we reverse engineering it in the way implemented in > > this patch set. > > Have you made sure this layout is the same on all uarchitectures that > implment VMX? He's determining the layout at runtime. It should even work with kvm's vmx implementation. It's vulnerable to two issues: - fields that are cached in the processor and not flushed to memory (perhaps just make sure to VMXOFF before dumping memory) - fields that are encoded differently in memory than VMREAD/VMWRITE -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756323Ab2DKKt3 (ORCPT ); Wed, 11 Apr 2012 06:49:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50774 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125Ab2DKKt2 (ORCPT ); Wed, 11 Apr 2012 06:49:28 -0400 Message-ID: <4F8561A7.80604@redhat.com> Date: Wed, 11 Apr 2012 13:49:11 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120316 Thunderbird/11.0 MIME-Version: 1.0 To: Joerg Roedel CC: zhangyanfei , mtosatti@redhat.com, ebiederm@xmission.com, luto@mit.edu, dzickus@redhat.com, paul.gortmaker@windriver.com, gregkh@suse.de, ludwig.nussel@suse.de, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH 0/4] Export offsets of VMCS fields as note information for kdump References: <4F84E0DF.8040206@cn.fujitsu.com> <20120411102136.GG2428@amd.com> In-Reply-To: <20120411102136.GG2428@amd.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/11/2012 01:21 PM, Joerg Roedel wrote: > Hi, > > On Wed, Apr 11, 2012 at 09:39:43AM +0800, zhangyanfei wrote: > > The problem is that VMCS internal is hidden by Intel in its > > specification. So, we reverse engineering it in the way implemented in > > this patch set. > > Have you made sure this layout is the same on all uarchitectures that > implment VMX? He's determining the layout at runtime. It should even work with kvm's vmx implementation. It's vulnerable to two issues: - fields that are cached in the processor and not flushed to memory (perhaps just make sure to VMXOFF before dumping memory) - fields that are encoded differently in memory than VMREAD/VMWRITE -- error compiling committee.c: too many arguments to function