From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SHvw6-0005iW-CC for kexec@lists.infradead.org; Wed, 11 Apr 2012 11:42:07 +0000 Message-ID: <4F856E03.1060601@redhat.com> Date: Wed, 11 Apr 2012 14:41:55 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [PATCH 2/4] KVM: VMX: Add functions to fill VMCSINFO References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E365.10201@cn.fujitsu.com> <4F85454E.6020201@redhat.com> <4F855E3C.9010003@cn.fujitsu.com> In-Reply-To: <4F855E3C.9010003@cn.fujitsu.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: zhangyanfei Cc: dzickus@redhat.com, luto@mit.edu, gregkh@suse.de, kvm@vger.kernel.org, joerg.roedel@amd.com, mtosatti@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, ebiederm@xmission.com T24gMDQvMTEvMjAxMiAwMTozNCBQTSwgemhhbmd5YW5mZWkgd3JvdGU6Cj4g5LqOIDIwMTLlubQw NOaciDEx5pelIDE2OjQ4LCBBdmkgS2l2aXR5IOWGmemBkzoKPiA+IE9uIDA0LzExLzIwMTIgMDQ6 NTAgQU0sIHpoYW5neWFuZmVpIHdyb3RlOgo+ID4+IFRoaXMgcGF0Y2ggaXMgdG8gaW1wbGVtZW50 IHRoZSBmZWF0dXJlIHRoYXQgYXQgaW5pdGlhbGl6YXRpb24gb2YKPiA+PiBrdm1faW50ZWwgbW9k dWxlLCBmaWxscyBWTUNTSU5GTyB3aXRoIGEgVk1DUyByZXZpc2lvbiBpZGVudGlmaWVyLAo+ID4+ IGFuZCBlbmNvZGVkIG9mZnNldHMgb2YgVk1DUyBmaWVsZHMuIFRoZSByZWFzb24gd2h5IHdlIHB1 dCB0aGUKPiA+PiBWTUNTSU5GTyBwcm9jZXNzaW5nIGF0IHRoZSBpbml0aWFsaXphdGlvbiBvZiBr dm1faW50ZWwgbW9kdWxlCj4gPj4gaXMgdGhhdCBpdCdzIGRhbmdlcm91cyB0byByb2IgVk1YIHJl c291cmNlcyB3aGlsZSBrdm0gbW9kdWxlIGlzCj4gPj4gbG9hZGVkLgo+ID4gCj4gPiBNYXliZSBp dCBzaG91bGQgYmUgZG9uZSBieSBhIHNlcGFyYXRlIG1vZHVsZS4KPiA+IAo+Cj4gSWYgd2UgcHV0 IHZtY3NpbmZvIHByb2Nlc3NpbmcgYXQgdGhlIGluaXRpYWxpemF0aW9uIG9mIGt2bV9pbnRlbCBt b2R1bGUsCj4gYXMgc29vbiBhcyB0aGUga3ZtX2ludGVsIG1vZHVsZSBpcyBsb2FkZWQsIFZNQ1NJ TkZPIGlzIGZpbGxlZC4gQW5kIGl0IGlzCj4gYmVjYXVzZSB2bWNzaW5mbyBwcm9jZXNzaW5nIGlz IGF0IHRoZSBpbml0aWFsaXphdGlvbiBvZiBrdm1faW50ZWwgbW9kdWxlLAo+IG5vIGt2bSBndWVz dHMgYXJlIHJ1bm5pbmcsIHNvIGl0IHdpbGwgbm90IHJvYiBhbnkgVk1YIHJlc291cmNlcy4KPgo+ IElmIGl0IGlzIGRvbmUgYnkgYSBzZXBhcmF0ZSBtb2R1bGUsIEkgYW0gYWZyYWlkIHRoaXMgbW9k dWxlIG1heSBub3QgYmUKPiBsb2FkZWQgd2hlbiB0aGUga2VybmVsIG5lZWRzIFZNQ1NJTkZPLgo+ CgpZb3UgY2FuIG1ha2UgdGhlIG1vZHVsZSBhdXRvbG9hZCB3aGVuIHRoZSB2bXggY3B1ZmVhdHVy ZSBpcyBkZXRlY3RlZC4gCkJ1dCB0aGVuIHRoZXJlIGlzIGFuIG9yZGVyaW5nIHByb2JsZW0gd3J0 IGt2bS1pbnRlbC4KCi0tIAplcnJvciBjb21waWxpbmcgY29tbWl0dGVlLmM6IHRvbyBtYW55IGFy Z3VtZW50cyB0byBmdW5jdGlvbgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/4] KVM: VMX: Add functions to fill VMCSINFO Date: Wed, 11 Apr 2012 14:41:55 +0300 Message-ID: <4F856E03.1060601@redhat.com> References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E365.10201@cn.fujitsu.com> <4F85454E.6020201@redhat.com> <4F855E3C.9010003@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: dzickus-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, luto-3s7WtUTddSA@public.gmane.org, gregkh-l3A5Bk7waGM@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, joerg.roedel-5C7GfCeVMHo@public.gmane.org, mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org, ludwig.nussel-l3A5Bk7waGM@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org To: zhangyanfei Return-path: In-Reply-To: <4F855E3C.9010003-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org T24gMDQvMTEvMjAxMiAwMTozNCBQTSwgemhhbmd5YW5mZWkgd3JvdGU6Cj4g5LqOIDIwMTLlubQw NOaciDEx5pelIDE2OjQ4LCBBdmkgS2l2aXR5IOWGmemBkzoKPiA+IE9uIDA0LzExLzIwMTIgMDQ6 NTAgQU0sIHpoYW5neWFuZmVpIHdyb3RlOgo+ID4+IFRoaXMgcGF0Y2ggaXMgdG8gaW1wbGVtZW50 IHRoZSBmZWF0dXJlIHRoYXQgYXQgaW5pdGlhbGl6YXRpb24gb2YKPiA+PiBrdm1faW50ZWwgbW9k dWxlLCBmaWxscyBWTUNTSU5GTyB3aXRoIGEgVk1DUyByZXZpc2lvbiBpZGVudGlmaWVyLAo+ID4+ IGFuZCBlbmNvZGVkIG9mZnNldHMgb2YgVk1DUyBmaWVsZHMuIFRoZSByZWFzb24gd2h5IHdlIHB1 dCB0aGUKPiA+PiBWTUNTSU5GTyBwcm9jZXNzaW5nIGF0IHRoZSBpbml0aWFsaXphdGlvbiBvZiBr dm1faW50ZWwgbW9kdWxlCj4gPj4gaXMgdGhhdCBpdCdzIGRhbmdlcm91cyB0byByb2IgVk1YIHJl c291cmNlcyB3aGlsZSBrdm0gbW9kdWxlIGlzCj4gPj4gbG9hZGVkLgo+ID4gCj4gPiBNYXliZSBp dCBzaG91bGQgYmUgZG9uZSBieSBhIHNlcGFyYXRlIG1vZHVsZS4KPiA+IAo+Cj4gSWYgd2UgcHV0 IHZtY3NpbmZvIHByb2Nlc3NpbmcgYXQgdGhlIGluaXRpYWxpemF0aW9uIG9mIGt2bV9pbnRlbCBt b2R1bGUsCj4gYXMgc29vbiBhcyB0aGUga3ZtX2ludGVsIG1vZHVsZSBpcyBsb2FkZWQsIFZNQ1NJ TkZPIGlzIGZpbGxlZC4gQW5kIGl0IGlzCj4gYmVjYXVzZSB2bWNzaW5mbyBwcm9jZXNzaW5nIGlz IGF0IHRoZSBpbml0aWFsaXphdGlvbiBvZiBrdm1faW50ZWwgbW9kdWxlLAo+IG5vIGt2bSBndWVz dHMgYXJlIHJ1bm5pbmcsIHNvIGl0IHdpbGwgbm90IHJvYiBhbnkgVk1YIHJlc291cmNlcy4KPgo+ IElmIGl0IGlzIGRvbmUgYnkgYSBzZXBhcmF0ZSBtb2R1bGUsIEkgYW0gYWZyYWlkIHRoaXMgbW9k dWxlIG1heSBub3QgYmUKPiBsb2FkZWQgd2hlbiB0aGUga2VybmVsIG5lZWRzIFZNQ1NJTkZPLgo+ CgpZb3UgY2FuIG1ha2UgdGhlIG1vZHVsZSBhdXRvbG9hZCB3aGVuIHRoZSB2bXggY3B1ZmVhdHVy ZSBpcyBkZXRlY3RlZC4gCkJ1dCB0aGVuIHRoZXJlIGlzIGFuIG9yZGVyaW5nIHByb2JsZW0gd3J0 IGt2bS1pbnRlbC4KCi0tIAplcnJvciBjb21waWxpbmcgY29tbWl0dGVlLmM6IHRvbyBtYW55IGFy Z3VtZW50cyB0byBmdW5jdGlvbgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758243Ab2DKLmO (ORCPT ); Wed, 11 Apr 2012 07:42:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40904 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508Ab2DKLmN (ORCPT ); Wed, 11 Apr 2012 07:42:13 -0400 Message-ID: <4F856E03.1060601@redhat.com> Date: Wed, 11 Apr 2012 14:41:55 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120316 Thunderbird/11.0 MIME-Version: 1.0 To: zhangyanfei CC: mtosatti@redhat.com, ebiederm@xmission.com, luto@mit.edu, joerg.roedel@amd.com, dzickus@redhat.com, paul.gortmaker@windriver.com, gregkh@suse.de, ludwig.nussel@suse.de, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH 2/4] KVM: VMX: Add functions to fill VMCSINFO References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E365.10201@cn.fujitsu.com> <4F85454E.6020201@redhat.com> <4F855E3C.9010003@cn.fujitsu.com> In-Reply-To: <4F855E3C.9010003@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/11/2012 01:34 PM, zhangyanfei wrote: > 于 2012年04月11日 16:48, Avi Kivity 写道: > > On 04/11/2012 04:50 AM, zhangyanfei wrote: > >> This patch is to implement the feature that at initialization of > >> kvm_intel module, fills VMCSINFO with a VMCS revision identifier, > >> and encoded offsets of VMCS fields. The reason why we put the > >> VMCSINFO processing at the initialization of kvm_intel module > >> is that it's dangerous to rob VMX resources while kvm module is > >> loaded. > > > > Maybe it should be done by a separate module. > > > > If we put vmcsinfo processing at the initialization of kvm_intel module, > as soon as the kvm_intel module is loaded, VMCSINFO is filled. And it is > because vmcsinfo processing is at the initialization of kvm_intel module, > no kvm guests are running, so it will not rob any VMX resources. > > If it is done by a separate module, I am afraid this module may not be > loaded when the kernel needs VMCSINFO. > You can make the module autoload when the vmx cpufeature is detected. But then there is an ordering problem wrt kvm-intel. -- error compiling committee.c: too many arguments to function