From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jiang Liu <liuj97@gmail.com>, Yinghai Lu <yinghai@kernel.org>,
Taku Izumi <izumi.taku@jp.fujitsu.com>,
Jiang Liu <jiang.liu@huawei.com>,
Keping Chen <chenkeping@huawei.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH V4 0/6] PCI, x86: update MMCFG information when hot-plugging PCI host bridges
Date: Wed, 11 Apr 2012 21:05:56 +0900 [thread overview]
Message-ID: <4F8573A4.8070307@jp.fujitsu.com> (raw)
In-Reply-To: <CAErSpo7zWEXBhC7+gaq+BCussyKOYORaBG-PBe4ERruCAA-cfQ@mail.gmail.com>
(2012/04/11 13:02), Bjorn Helgaas wrote:
> On Tue, Apr 10, 2012 at 6:10 PM, Jiang Liu<liuj97@gmail.com> wrote:
>> This patchset enhance pci_root driver to update MMCFG information when
>> hot-plugging PCI root bridges. It applies to Yinghai's tree at
>> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-pci-root-bus-hotplug
>>
>> The second patch is based on Taku Izumi work with some enhancements to
>> correctly handle PCI host bridges without _CBA method.
>
> I'm sorry I won't have time to really review these for a couple weeks.
>
> It always seemed wrong to me that we parse MCFG and set things up
> before we even look at PNP0A03/PNP0A08 devices. It would make more
> sense to me to have something in acpi_pci_root_add() to set up
> MMCONFIG using _CBA if available, and falling back to parsing MCFG if
> it's not.
I think your idea could make the code (design) much cleaner.
Do you have any other reason why you think "It always seemed
wrong..."?
Regards,
Kenji Kaneshige
next prev parent reply other threads:[~2012-04-11 12:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 0:10 [PATCH V4 0/6] PCI, x86: update MMCFG information when hot-plugging PCI host bridges Jiang Liu
2012-04-11 0:10 ` [PATCH V4 1/6] PCI, x86: split out pci_mmcfg_check_reserved() for code reuse Jiang Liu
2012-04-11 0:10 ` [PATCH V4 2/6] PCI, x86: split out pci_mmconfig_alloc() " Jiang Liu
2012-04-11 0:11 ` [PATCH V4 3/6] PCI, x86: use RCU list to protect mmconfig list Jiang Liu
2012-04-11 0:11 ` [PATCH V4 4/6] PCI, x86: introduce pci_mmcfg_arch_map()/pci_mmcfg_arch_unmap() Jiang Liu
2012-04-11 0:11 ` [PATCH V4 5/6] PCI, x86: introduce pci_mmconfig_insert()/delete() for PCI root bridge hotplug Jiang Liu
2012-04-11 0:11 ` [PATCH V4 6/6] PCI, ACPI, x86: update MMCFG information when hot-plugging PCI host bridges Jiang Liu
2012-04-18 6:47 ` Taku Izumi
2012-04-18 7:49 ` Jiang Liu
2012-04-19 6:49 ` Taku Izumi
2012-04-19 7:04 ` Jiang Liu
2012-04-11 4:02 ` [PATCH V4 0/6] PCI, " Bjorn Helgaas
2012-04-11 12:05 ` Kenji Kaneshige [this message]
2012-04-11 15:34 ` Jiang Liu
2012-04-12 0:06 ` Bjorn Helgaas
2012-04-13 10:48 ` Kenji Kaneshige
2012-04-13 14:33 ` Jiang Liu
2012-04-16 15:30 ` Don Dutile
2012-04-16 16:09 ` Jiang Liu
2012-04-16 17:54 ` Don Dutile
2012-04-23 17:41 ` Bjorn Helgaas
2012-04-23 18:50 ` Don Dutile
2012-04-25 16:50 ` Bjorn Helgaas
2012-04-26 3:35 ` Don Dutile
2012-04-26 3:53 ` Jiang Liu
2012-04-26 4:02 ` Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8573A4.8070307@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=bhelgaas@google.com \
--cc=chenkeping@huawei.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=linux-pci@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.