From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Fabio Baltieri <fabio.baltieri@gmail.com>
Cc: linux-can@vger.kernel.org
Subject: Re: [RFC PATCH] can: add tx/rx led trigger support
Date: Wed, 11 Apr 2012 21:02:43 +0200 [thread overview]
Message-ID: <4F85D553.2010303@hartkopp.net> (raw)
In-Reply-To: <CABkP77eNeTTwSxtKyfUmr7OC4H1nXEN4EeFH7pdR6=BcpKuE6w@mail.gmail.com>
Two additional questions:
On 11.04.2012 19:58, Fabio Baltieri wrote:
> On Wed, Apr 11, 2012 at 8:14 AM, Oliver Hartkopp <socketcan@hartkopp.net> wrote:
>> And we should probably add a new CAN netlink command here
>>
>> http://lxr.linux.no/#linux+v3.3.1/drivers/net/can/dev.c#L577
>>
>> to configure the LED timer per interface: 0 -> LEDs off (==default)
>
> Nice... I'm taking notes here. :-)
Hm - probably this is a bit heavy weighted suggestion from me.
Do you really think the timer value needs to be configurable or is a simple
on/off switch ok too?
The second question:
Is the LED "blinking" on traffic or is it just "on" for some time when a CAN
frame is processed?
Regards,
Oliver
next prev parent reply other threads:[~2012-04-11 19:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 21:39 [RFC PATCH] can: add tx/rx led trigger support Fabio Baltieri
2012-04-11 6:14 ` Oliver Hartkopp
2012-04-11 17:58 ` Fabio Baltieri
2012-04-11 18:29 ` Oliver Hartkopp
2012-04-11 18:58 ` Wolfgang Grandegger
2012-04-12 6:16 ` Oliver Hartkopp
2012-04-11 19:02 ` Oliver Hartkopp [this message]
2012-04-11 19:36 ` Fabio Baltieri
2012-04-12 6:05 ` Oliver Hartkopp
2012-04-12 6:32 ` Alexander Stein
2012-04-12 15:52 ` Oliver Hartkopp
2012-04-12 18:30 ` Fabio Baltieri
2012-04-13 19:00 ` Oliver Hartkopp
2012-04-12 7:37 ` Wolfgang Grandegger
2012-04-12 11:07 ` Martin Gysel
2012-04-12 16:02 ` Oliver Hartkopp
2012-04-12 16:13 ` Wolfgang Grandegger
2012-04-12 17:28 ` Fabio Baltieri
2012-04-12 18:47 ` Wolfgang Grandegger
2012-04-12 17:46 ` Fabio Baltieri
2012-04-12 18:53 ` Wolfgang Grandegger
2012-04-11 6:29 ` Alexander Stein
2012-04-11 18:03 ` Fabio Baltieri
2012-04-11 14:45 ` Wolfgang Grandegger
2012-04-11 16:24 ` Oliver Hartkopp
2012-04-11 19:11 ` Fabio Baltieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F85D553.2010303@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=fabio.baltieri@gmail.com \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.