All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Ying Han <yinghan@google.com>
Cc: Michal Hocko <mhocko@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mel@csn.ul.ie>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Hillf Danton <dhillf@gmail.com>, Hugh Dickins <hughd@google.com>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH V2 3/5] memcg: set soft_limit_in_bytes to 0 by default
Date: Wed, 11 Apr 2012 20:45:33 -0400	[thread overview]
Message-ID: <4F8625AD.6000707@redhat.com> (raw)
In-Reply-To: <1334181614-26836-1-git-send-email-yinghan@google.com>

On 04/11/2012 06:00 PM, Ying Han wrote:
> 1. If soft_limit are all set to MAX, it wastes first three periority iterations
> without scanning anything.
>
> 2. By default every memcg is eligibal for softlimit reclaim, and we can also
> set the value to MAX for special memcg which is immune to soft limit reclaim.
>
> This idea is based on discussion with Michal and Johannes from LSF.

Combined with patch 2/5, would this not result in always
returning "reclaim from this memcg" for groups without a
configured softlimit, while groups with a configured
softlimit only get reclaimed from when they are over
their limit?

Is that the desired behaviour when a system has some
cgroups with a configured softlimit, and some without?

-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-04-12  0:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 22:00 [PATCH V2 3/5] memcg: set soft_limit_in_bytes to 0 by default Ying Han
2012-04-12  0:45 ` Rik van Riel [this message]
2012-04-12  2:22   ` Johannes Weiner
2012-04-16 15:15     ` Michal Hocko
2012-04-16 16:33       ` Ying Han
2012-04-12  3:46   ` Ying Han
2012-04-14 13:35 ` Hillf Danton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8625AD.6000707@redhat.com \
    --to=riel@redhat.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=dhillf@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=mhocko@suse.cz \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.