From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?5p6X5b2l5L2R?= Subject: Re: [PATCH v3] Input: Elan HID-I2C device driver Date: Thu, 12 Apr 2012 09:37:12 +0800 Message-ID: <4F8631C8.1090705@emc.com.tw> References: <1334061766-20577-1-git-send-email-tom_lin@emc.com.tw> <20120411071212.GB6894@core.coreip.homeip.net> <4F85583F.6050008@emc.com.tw> <20120411162519.GA27562@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20120411162519.GA27562@core.coreip.homeip.net> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, djkurtz@chromium.org, Jiri Kosina List-Id: linux-input@vger.kernel.org Hi Dmitry On 04/12/2012 12:25 AM, Dmitry Torokhov wrote: > On Wednesday, April 11, 2012 06:09:03 PM =E6=9E=97=E5=BD=A5=E4=BD=91 = wrote: >> Hi Daniel >> >> On 04/11/2012 03:12 PM, Dmitry Torokhov wrote: >>> Hi Tom, >>> >>> On Tue, Apr 10, 2012 at 08:42:46PM +0800, Tom Lin wrote: >>>> This patch adds driver for Elan I2C touchpad. These protocol of HI= D-I2C >>>> was >>>> defined by Microsoft. The kernel driver would use the multi-touch >>>> protocol >>>> format B. >>> >>> If this device truly supports HID protocol shouldn't we define i2c-= hid >>> transport, similar to usbhid? >> >> I merely follow defined by Microsoft. >> It was called "HID OVER I2C" by Microsoft. >> (http://msdn.microsoft.com/en-us/library/windows/hardware/hh825917(v= =3Dvs.85). >> aspx) But I agree to change from hid i2c to i2chid. >> Do you have any better opinions? > > I am not sure we are talking about same thing... I do not really care > whether it is named "hid i2c" or "i2chid". What I meant if the device > really speaks HID protocol, except that the transport is not USB or > bluetooth but I2C, then instead of writing a custom driver for this > particular part we need to add a new HID transport into > drivers/hid/i2c-hid that is similar to drivers/hid/usbhid/ and reuse = the > rest of HID framework along with hid- multitouch.c which handles > HID-compliant multitouch devices. > > I am CCing Jiri (HID maintainer) for additional input. Sorry! I misunderstood what you mean. I fully agree with your suggestion. The I2CHID device will be more and=20 more in the future. Need the new i2chid-driver that would cover all=20 hid-compliant i2c-devices. Thank you Tom- > > Thanks. >