From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: Checkpatch warnings with pr_fmt()
Date: Thu, 12 Apr 2012 10:32:54 +0300 [thread overview]
Message-ID: <4F868526.5020703@qca.qualcomm.com> (raw)
In-Reply-To: <4F868445.1030209@qca.qualcomm.com>
On 04/12/2012 10:29 AM, Kalle Valo wrote:
> Hi Joe,
>
> due to checkpatch warnings in ath6kl, from a recent pr_fmt() addition, I
> had to update checkpatch and now I get lots of useless warnings like this:
>
> drivers/net/wireless/ath/ath6kl/common.h:28: CHECK: Don't begin block
> comments with only a /* line, use /* comment...
> drivers/net/wireless/ath/ath6kl/bmi.h:233: CHECK: No space is necessary
> after a cast
>
> IMHO they are wrong, at least the style I have tried to enforce in
> ath6kl is totally opposite (I have "/*\n" on multiline comments and a
> space after a cast). And at least CodingStyle seems to recommend my
> style for the multiline comments.
>
> Would you consider removing these two warnings? Or maybe add a new check
> level so that I can easily disable them?
>
> As I get a lot of patches from people not familiar with the Linux coding
> style checkpatch is a valuable tool for me, I cannot spot all the style
> issues by just reviewing the patches. But now checkpatch is useless for
> me as the real warnings get buried within the noise.
Forgot to mention that for now I just reverted commit aad4f614983
("checkpatch: add --strict tests for braces, comments and casts") and
checkpatch is usable again. But I hope we find a proper solution for this.
Kalle
next prev parent reply other threads:[~2012-04-12 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 7:29 Checkpatch warnings with pr_fmt() Kalle Valo
2012-04-12 7:32 ` Kalle Valo [this message]
2012-04-16 19:18 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F868526.5020703@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.