From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:42399 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757583Ab2DLPgn (ORCPT ); Thu, 12 Apr 2012 11:36:43 -0400 Message-ID: <4F86F685.1090707@wwwdotorg.org> Date: Thu, 12 Apr 2012 09:36:37 -0600 From: Stephen Warren MIME-Version: 1.0 To: Laxman Dewangan CC: jic23@cam.ac.uk, gregkh@linuxfoundation.org, grant.likely@secretlab.ca, rob.herring@calxeda.com, jbrenner@taosinc.com, rklein@nvidia.com, max@stro.at, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Subject: Re: [PATCH V4 2/2] staging: iio: add driver for isl29028 References: <1334239266-29505-1-git-send-email-ldewangan@nvidia.com> <1334239266-29505-3-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1334239266-29505-3-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 04/12/2012 08:01 AM, Laxman Dewangan wrote: > Intersil's ISL29028 is concurrent Ambient Light and > Proximity Sensor device. > Add driver to access the light and IR intensity and > +static const struct regmap_config isl29028_regmap_config = { ... > + .max_register = ISL29028_MAX_REGS - 1, > + .num_reg_defaults_raw = ISL29028_MAX_REGS, This should really be ISL29028_NUM_REGS, since you don't have a maximum number of registers, just a number of regs. However, if there's no other reason to respin the patch, don't worry about it. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V4 2/2] staging: iio: add driver for isl29028 Date: Thu, 12 Apr 2012 09:36:37 -0600 Message-ID: <4F86F685.1090707@wwwdotorg.org> References: <1334239266-29505-1-git-send-email-ldewangan@nvidia.com> <1334239266-29505-3-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1334239266-29505-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, jbrenner-yYKgigLBUwlBDgjK7y7TUQ@public.gmane.org, rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, max-U9r9yeDMy7A@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On 04/12/2012 08:01 AM, Laxman Dewangan wrote: > Intersil's ISL29028 is concurrent Ambient Light and > Proximity Sensor device. > Add driver to access the light and IR intensity and > +static const struct regmap_config isl29028_regmap_config = { ... > + .max_register = ISL29028_MAX_REGS - 1, > + .num_reg_defaults_raw = ISL29028_MAX_REGS, This should really be ISL29028_NUM_REGS, since you don't have a maximum number of registers, just a number of regs. However, if there's no other reason to respin the patch, don't worry about it.