From mboxrd@z Thu Jan 1 00:00:00 1970 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH v1 0/7] memcg remove pre_destroy Date: Fri, 13 Apr 2012 08:59:44 +0900 Message-ID: <4F876C70.7060600@jp.fujitsu.com> References: <4F86B9BE.8000105@jp.fujitsu.com> <20120412160642.GA13069@google.com>User-Agent: Notmuch/0.11.1+346~g13d19c3 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) <877gxksrq1.fsf@skywalker.in.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <877gxksrq1.fsf@skywalker.in.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" To: "Aneesh Kumar K.V" Cc: Tejun Heo , "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Glauber Costa , Hugh Dickins , Andrew Morton (2012/04/13 3:57), Aneesh Kumar K.V wrote: > Tejun Heo writes: > >> Hello, KAMEZAWA. >> >> Thanks a lot for doing this. >> >> On Thu, Apr 12, 2012 at 08:17:18PM +0900, KAMEZAWA Hiroyuki wrote: >>> In recent discussion, Tejun Heo, cgroup maintainer, has a plan to remove >>> ->pre_destroy(). And now, in cgroup tree, pre_destroy() failure cause WARNING. >> >> Just to clarify, I'm not intending to ->pre_destroy() per-se but the >> retry behavior of it, so ->pre_destroy() will be converted to return >> void and called once on rmdir and rmdir will proceed no matter what. >> Also, with the deprecated behavior flag set, pre_destroy() doesn't >> trigger the warning message. >> >> Other than that, if memcg people are fine with the change, I'll be >> happy to route the changes through cgroup/for-3.5 and stack rmdir >> simplification patches on top. >> > > Any suggestion on how to take HugeTLB memcg extension patches [1] > upstream. Current patch series I have is on top of cgroup/for-3.5 > because I need cgroup_add_files equivalent and cgroup/for-3.5 have > changes around that. So if these memcg patches can also go on top of > cgroup/for-3.5 then I can continue to work on top of cgroup/for-3.5 ? > > Can HugeTLB memcg extension patches also go via this tree ? It > should actually got via -mm. But then how do we take care of these > dependencies ? > I'm not in hurry. To be honest, I cannot update patches until the next Wednesday. So, If changes of cgroup tree you required are included in linux-next. Please post your updated ones. I thought your latest version was near to be merged.... How do you think, Michal ? Please post (and ask Andrew to pull it.) I'll review when I can. I know yours and mine has some conflicts. I think my this series will be onto your series. To do that, I hope your series are merged to linux-next, 1st. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org